You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@activemq.apache.org by "David Carlier (JIRA)" <ji...@apache.org> on 2017/03/28 13:09:41 UTC

[jira] [Updated] (AMQCPP-612) System::arraycopy weird tests

     [ https://issues.apache.org/jira/browse/AMQCPP-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Carlier updated AMQCPP-612:
---------------------------------
    Description: 
Hi,

I was reading the source code especially System::arraycopy family methods :

https://git-wip-us.apache.org/repos/asf?p=activemq-cpp.git;a=blob;f=activemq-cpp/src/main/decaf/lang/System.cpp;h=199dd660ca58a23862e93109fa9827444728bf13;hb=HEAD#l120

and was wonderined if :
- Testing twice src was intentional since I suppose it should be dest as second test for example ?
- Should not it be always memmove since src and dest can still overlap ?

Regards.

  was:
Hi,

I was reading the source code especially System::arraycopy family methods :

https://git-wip-us.apache.org/repos/asf?p=activemq-cpp.git;a=blob;f=activemq-cpp/src/main/decaf/lang/System.cpp;h=199dd660ca58a23862e93109fa9827444728bf13;hb=HEAD#l120

and was wonderined if :
- Testing twice src was intentional since I suppose it should be dst as second test for example ?
- Should not it be always memmove since src and dst can still overlap ?

Regards.


> System::arraycopy weird tests
> -----------------------------
>
>                 Key: AMQCPP-612
>                 URL: https://issues.apache.org/jira/browse/AMQCPP-612
>             Project: ActiveMQ C++ Client
>          Issue Type: Bug
>          Components: Decaf
>    Affects Versions: 3.9.5
>            Reporter: David Carlier
>            Assignee: Timothy Bish
>            Priority: Minor
>
> Hi,
> I was reading the source code especially System::arraycopy family methods :
> https://git-wip-us.apache.org/repos/asf?p=activemq-cpp.git;a=blob;f=activemq-cpp/src/main/decaf/lang/System.cpp;h=199dd660ca58a23862e93109fa9827444728bf13;hb=HEAD#l120
> and was wonderined if :
> - Testing twice src was intentional since I suppose it should be dest as second test for example ?
> - Should not it be always memmove since src and dest can still overlap ?
> Regards.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)