You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/11/30 00:37:20 UTC
[PR] [SPARK-46177][PYTHON][CONNECT][ML][TESTS] Skip 'CrossValidatorTests.test_crossvalidator_with_fold_col' with Python 3.12 [spark]
HyukjinKwon opened a new pull request, #44086:
URL: https://github.com/apache/spark/pull/44086
### What changes were proposed in this pull request?
This PR proposes to skip doctest, `CrossValidatorTests.test_crossvalidator_with_fold_col`, compatible with Python 3.12.
### Why are the changes needed?
- For the proper test for Python 3.12. It is failing, see SPARK-46177 and https://github.com/apache/spark/actions/runs/7034467411/job/19154766502
- Current dev torch version does not work very well with Python 3.12. It should be enabled together with SPARK-46078.
- The build with Python 3.12 halts so can't see if other tests pass fine.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
Manually tested.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46177][PYTHON][CONNECT][ML][TESTS] Skip 'CrossValidatorTests.test_crossvalidator_with_fold_col' with Python 3.12 [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44086: [SPARK-46177][PYTHON][CONNECT][ML][TESTS] Skip 'CrossValidatorTests.test_crossvalidator_with_fold_col' with Python 3.12
URL: https://github.com/apache/spark/pull/44086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46177][PYTHON][CONNECT][ML][TESTS] Skip 'CrossValidatorTests.test_crossvalidator_with_fold_col' with Python 3.12 [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44086:
URL: https://github.com/apache/spark/pull/44086#issuecomment-1832929146
Build: https://github.com/HyukjinKwon/spark/actions/runs/7040333718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46177][PYTHON][CONNECT][ML][TESTS] Skip 'CrossValidatorTests.test_crossvalidator_with_fold_col' with Python 3.12 [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44086:
URL: https://github.com/apache/spark/pull/44086#issuecomment-1833098139
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org