You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/11 09:44:11 UTC
[GitHub] [flink-kubernetes-operator] czy006 opened a new pull request, #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
czy006 opened a new pull request, #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308
## What is the purpose of the change
[FLINK-28223] Add artifact-fetcher to the pod-template.yaml example to doc
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1193833388
Hi @czy006 please simply update the pod-template yaml with this:
```
apiVersion: flink.apache.org/v1beta1
kind: FlinkDeployment
metadata:
name: pod-template-example
spec:
image: flink:1.15
flinkVersion: v1_15
flinkConfiguration:
taskmanager.numberOfTaskSlots: "2"
serviceAccount: flink
podTemplate:
apiVersion: v1
kind: Pod
metadata:
name: pod-template
spec:
containers:
# Do not change the main container name
- name: flink-main-container
volumeMounts:
- mountPath: /opt/flink/log
name: flink-logs
- mountPath: /opt/flink/downloads
name: downloads
# Sample sidecar container for log forwarding
- name: fluentbit
image: fluent/fluent-bit:1.9.6-debug
command: [ 'sh','-c','/fluent-bit/bin/fluent-bit -i tail -p path=/flink-logs/*.log -p multiline.parser=java -o stdout' ]
volumeMounts:
- mountPath: /flink-logs
name: flink-logs
volumes:
- name: flink-logs
emptyDir: { }
- name: downloads
emptyDir: { }
jobManager:
resource:
memory: "2048m"
cpu: 1
podTemplate:
apiVersion: v1
kind: Pod
metadata:
name: task-manager-pod-template
spec:
initContainers:
# Sample init container for fetching remote artifacts
- name: busybox
image: busybox:latest
volumeMounts:
- mountPath: /opt/flink/downloads
name: downloads
command:
- /bin/sh
- -c
- "wget -O /opt/flink/downloads/flink-examples-streaming.jar \
https://repo1.maven.org/maven2/org/apache/flink/flink-examples-streaming_2.12/1.15.1/flink-examples-streaming_2.12-1.15.1.jar"
taskManager:
resource:
memory: "2048m"
cpu: 1
job:
jarURI: local:///opt/flink/downloads/flink-examples-streaming.jar
entryClass: org.apache.flink.streaming.examples.statemachine.StateMachineExample
parallelism: 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1180402511
Please add instructions how to test your example to the PR description. The example should work as-is on the local Kube-client environment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] czy006 commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
czy006 commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1196161652
@morhidi PLAT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1196498044
@czy006 thanks for demonstrating the doc working. I think some of @morhidi's asks got lost in terms of making this a mor concise change, I compacted it into the existing example while merging. Please see https://github.com/apache/flink-kubernetes-operator/commit/792350e8722a3cbe9b32b5bd65983a5e14541933.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1180401048
@czy006 you can use this example as a guide: https://hop.apache.org/manual/next/pipeline/beam/flink-k8s-operator-running-hop-pipeline.html obviously we need to change the S3 fetcher to some HTTP based one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] czy006 commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
czy006 commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1193248685
I try to copy the jar before running job,but it seems to not work becasue of not found the jar
I don't know what's problem with my initContainer define
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] czy006 commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
czy006 commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1193253310
Now k8s with docker job is running, before it I forget to add jm volumes define
PLAT @morhidi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] asfgit closed pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
URL: https://github.com/apache/flink-kubernetes-operator/pull/308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] czy006 commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
czy006 commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1192537029
@mbalassi sorry,i miss gamil. now on going do it,This will be completed in two days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] czy006 commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
czy006 commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1193248777
initContainer Sucess
@mbalassi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
mbalassi commented on code in PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#discussion_r917909509
##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -100,6 +100,66 @@ spec:
parallelism: 2
```
+We also provide a way to obtain the jar package remotely, which can avoid you repeating the packaging image every time
+```yaml
+apiVersion: flink.apache.org/v1beta1
+kind: FlinkDeployment
+metadata:
+ namespace: default
+ name: pod-template-example
+spec:
+ image: flink:1.15
+ flinkVersion: v1_15
Review Comment:
please add `spec.serviceAccount: flink`
##########
docs/content/docs/custom-resource/pod-template.md:
##########
@@ -100,6 +100,66 @@ spec:
parallelism: 2
```
+We also provide a way to obtain the jar package remotely, which can avoid you repeating the packaging image every time
Review Comment:
nit: "package remotely, which can avoid you repeating the packaging image every time" -> "package remotely to avoid repeating the image packaging on each iteration."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1196356658
+1 LGMT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#issuecomment-1186140926
Hi @czy006!
Can you please address the comments next week?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #308: [FLINK-28223] Add artifact-fetcher to the pod-template.yaml example
Posted by GitBox <gi...@apache.org>.
morhidi commented on code in PR #308:
URL: https://github.com/apache/flink-kubernetes-operator/pull/308#discussion_r930060228
##########
examples/pod-template-artifact-fetcher.yaml:
##########
@@ -0,0 +1,84 @@
+################################################################################
Review Comment:
Pls remove this file, this is just a duplicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org