You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2017/01/08 07:49:48 UTC
Review Request 55322: Used process::after instead of
process::RateLimiter.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55322/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
Used process::after instead of process::RateLimiter.
Diffs
-----
src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521
Diff: https://reviews.apache.org/r/55322/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 55322: Used process::after instead of
process::RateLimiter.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55322/#review163781
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/io/switchboard.cpp (line 30)
<https://reviews.apache.org/r/55322/#comment235282>
Did you mean to add this?
- Benjamin Mahler
On Jan. 8, 2017, 7:49 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55322/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 7:49 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used process::after instead of process::RateLimiter.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521
>
> Diff: https://reviews.apache.org/r/55322/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 55322: Used process::after instead of
process::RateLimiter.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55322/#review163957
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On Jan. 8, 2017, 7:49 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55322/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 7:49 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used process::after instead of process::RateLimiter.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521
>
> Diff: https://reviews.apache.org/r/55322/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 55322: Used process::after instead of
process::RateLimiter.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55322/#review163954
-----------------------------------------------------------
Ship it!
This will most likely fix https://issues.apache.org/jira/browse/MESOS-7036, mind mentioning the ticket here and updating the ticket?
Having said that, I'm curious whether we should work on a more general solution to prevent bugs like MESOS-7036 in the future. See the example test in MESOS-7036 for more information.
- Alexander Rukletsov
On Jan. 8, 2017, 7:49 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55322/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2017, 7:49 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used process::after instead of process::RateLimiter.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/io/switchboard.cpp c80627986f729255e3b3ad1fc9cfa6213e19c521
>
> Diff: https://reviews.apache.org/r/55322/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>