[GitHub] [incubator-superset] rusackas commented on a change in pull request #11075: style(sqllab): make database errors more clear and render as monospace

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11075:
URL: https://github.com/apache/incubator-superset/pull/11075#discussion_r495668103



##########
File path: superset-frontend/src/components/ErrorMessage/ErrorAlert.tsx
##########
@@ -40,6 +40,11 @@ const ErrorAlertDiv = styled.div<{ level: ErrorLevel }>`
     justify-content: space-between;
   }
 
+  .monospace {
+    font-family: monospace;

Review comment:
       If you were to use Emotion, you could make sure we use Fira Code here instead of the browser's go-to monospace font. 
   `${({ theme }) => theme.typography.families.monospace}`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org