[GitHub] [airflow] changrunner opened a new pull request #14725: Update concepts.rst

[GitBox <gi...@apache.org>]

changrunner opened a new pull request #14725:
URL: https://github.com/apache/airflow/pull/14725


   The --install-option should be --prefix as per pip docs version 21.0.1
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14725: Update concepts.rst

[GitBox <gi...@apache.org>]

boring-cyborg[bot] commented on pull request #14725:
URL: https://github.com/apache/airflow/pull/14725#issuecomment-796832131


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #14725: Update concepts.rst

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #14725:
URL: https://github.com/apache/airflow/pull/14725#issuecomment-828043871


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on a change in pull request #14725: Update concepts.rst

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #14725:
URL: https://github.com/apache/airflow/pull/14725#discussion_r593725061



##########
File path: docs/apache-airflow/concepts.rst
##########
@@ -1618,7 +1618,7 @@ do the same, but then it is more suitable to use a virtualenv and pip.
     mkdir zip_dag_contents
     cd zip_dag_contents
 
-    pip install --install-option="--install-lib=$PWD" my_useful_package
+    pip install --prefix=$PWD my_useful_package

Review comment:
       ```suggestion
       pip install --target=$PWD my_useful_package
   ```
   
   Re-reading the context, the zip file is loaded directly into `sys.path`, so I think it should use `pip install --target` instead. `--prefix` would give you a nested prefix structure (e.g. Python packages are installed into `$PREFIX/lib/pythonX.Y/site-packages`). `--target` gives you a flat structure that can be directly loaded into `sys.path`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] closed pull request #14725: Update concepts.rst

[GitBox <gi...@apache.org>]

github-actions[bot] closed pull request #14725:
URL: https://github.com/apache/airflow/pull/14725


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org