[GitHub] [spark] attilapiros commented on a diff in pull request #42402: [SPARK-44725][DOCS] Document `spark.network.timeoutInterval`

["attilapiros (via GitHub)" <gi...@apache.org>]

attilapiros commented on code in PR #42402:
URL: https://github.com/apache/spark/pull/42402#discussion_r1287753664


##########
docs/configuration.md:
##########
@@ -2397,6 +2397,14 @@ Apart from these, the following properties are also available, and may be useful
   </td>
   <td>1.3.0</td>
 </tr>
+<tr>
+  <td><code>spark.network.timeoutInterval</code></td>
+  <td>60s</td>

Review Comment:
   Check `spark.rpc.io.connectionCreationTimeout`, `spark.rpc.io.connectionTimeout`... and `park.rpc.askTimeout`. All of them referencing to another config where the default comes from.
   
   For  `spark.network.timeoutInterval` the default is:
   https://github.com/apache/spark/blob/418bba5ad6053449a141f3c9c31ed3ad998995b8/core/src/main/scala/org/apache/spark/internal/config/Network.scala#L48-L52
   
   So IMHO we should mention here `spark.storage.blockManagerTimeoutIntervalMs` as the default.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org