You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "Kevin Minder (JIRA)" <ji...@apache.org> on 2018/02/07 23:16:00 UTC
[jira] [Updated] (KNOX-1177) Retighten the rewrite rule on oozieui
to reduce false positives
[ https://issues.apache.org/jira/browse/KNOX-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Minder updated KNOX-1177:
-------------------------------
Description:
This was previously fixed in KNOX-1106 and my change KNOX-1172 inadvertently regressed this as there was no test for this use case.
Currently oozieui rule will match uri with any scheme, which sometimes could cause false positives. For example the following rule in oozieui will rewrite viewfs://ns-default/foo/bar/oozie/myfile.jar to [http://oozie:11000/oozie/myfile.jar]
<rule dir="IN" name="OOZIEUI/oozie/inbound/root" pattern="*://*:*/**/oozie/">
<rewrite template="{$serviceUrl[OOZIEUI]}/"/>
</rule>
The attached patch will tighten the rule to match only http and https schemes.
was:
Currently oozieui rule will match uri with any scheme, which sometimes could cause false positives. For example the following rule in oozieui will rewrite viewfs://ns-default/foo/bar/oozie/myfile.jar to http://oozie:11000/oozie/myfile.jar
<rule dir="IN" name="OOZIEUI/oozie/inbound/root" pattern="*://*:*/**/oozie/">
<rewrite template="{$serviceUrl[OOZIEUI]}/"/>
</rule>
The attached patch will tighten the rule to match only http and https schemes.
> Retighten the rewrite rule on oozieui to reduce false positives
> ---------------------------------------------------------------
>
> Key: KNOX-1177
> URL: https://issues.apache.org/jira/browse/KNOX-1177
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 0.14.0
> Reporter: Wei Han
> Assignee: Wei Han
> Priority: Trivial
> Fix For: 0.14.0
>
>
> This was previously fixed in KNOX-1106 and my change KNOX-1172 inadvertently regressed this as there was no test for this use case.
> Currently oozieui rule will match uri with any scheme, which sometimes could cause false positives. For example the following rule in oozieui will rewrite viewfs://ns-default/foo/bar/oozie/myfile.jar to [http://oozie:11000/oozie/myfile.jar]
> <rule dir="IN" name="OOZIEUI/oozie/inbound/root" pattern="*://*:*/**/oozie/">
> <rewrite template="{$serviceUrl[OOZIEUI]}/"/>
> </rule>
> The attached patch will tighten the rule to match only http and https schemes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)