You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "cloud-fan (via GitHub)" <gi...@apache.org> on 2025/01/09 02:13:44 UTC

Re: [PR] [SPARK-50749][SQL] Fix ordering bug in CommutativeExpression.gatherCommutative method [spark]

cloud-fan commented on code in PR #49392:
URL: https://github.com/apache/spark/pull/49392#discussion_r1908074445


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ArithmeticExpressionSuite.scala:
##########
@@ -1086,4 +1086,17 @@ class ArithmeticExpressionSuite extends SparkFunSuite with ExpressionEvalHelper
     checkEvaluation(IntegralDivide(Literal(Duration.ofDays(1)),
       Literal(Duration.ofHours(-5))), -4L)
   }
+
+  test("unit test for gatherCommutative()") {

Review Comment:
   can we move this test to `CanonicalizeSuite`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org