[T5] Patch submission questions: dependent patches, git.

[lasitha <la...@gmail.com>]

Hello all,  i'd like to submit a few patches related to
tapestry-hibernate but need some guidance on a couple of patch
submission protocols.  Apologies up front for the newbie questions - i
wasn't able to find anything relevant on the lists or apache developer
info pages.

1. Are dependent patches ok?  For example i have some new integration
tests that demonstrate issues, but part of that work was just setting
up the infrastructure to run integration tests in tapestry-hibernate.
I figure that part would be useful on its own (particularly if the
tests turn out not to be).  The patches for the tests would then
depend on the infrastructure patch.

2. I use 'git' to manage work locally, among other reasons because it
simplifies maintaining multiple patches against an active stream.  The
patches git generates are slightly different from those generated by
'svn diff'.  They do apply cleanly when fed into a regular GNU 'patch'
command, but i don't know if there are other concerns.  A quick search
didn't yield any tools to convert a git patch into one that looks
identical to an svn one, but i can look harder (or massage them
manually) if need be.  If your process is to apply submissions onto a
working copy via 'patch' then i don't anticipate any trouble, but
please let me know.

Thank you,
lasitha.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: [T5] Patch submission questions: dependent patches, git.

[lasitha <la...@gmail.com>]

On Nov 26, 2007 10:49 AM, Howard Lewis Ship <hl...@gmail.com> wrote:
> On Nov 25, 2007 11:02 AM, lasitha <la...@gmail.com> wrote:
> > 1. Are dependent patches ok?  For example i have some new integration
> > ...
>
> Can you wait for the first patch to be applied before providing the second?

Yes, of course.  As usual, you have simplified the problem :)

> > 2. I use 'git' to manage work locally, among other reasons because it
> > simplifies maintaining multiple patches against an active stream.  The
> > patches git generates are slightly different from those generated by
> > 'svn diff'.  They do apply cleanly when fed into a regular GNU 'patch'
> > ...
>
> Hopefully IntellIJ can understand this format.

I don't have intellij installed, unfortunately.  I could get an eval
copy and try this out, or should i just submit it and let you try?
Both eclipse and gnu patch are ok with it.  I had to strip the leading
folders with '-p1', but i can clean this up before submitting.

Thanks,
lasitha.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org

Re: [T5] Patch submission questions: dependent patches, git.

[Howard Lewis Ship <hl...@gmail.com>]

On Nov 25, 2007 11:02 AM, lasitha <la...@gmail.com> wrote:
> Hello all,  i'd like to submit a few patches related to
> tapestry-hibernate but need some guidance on a couple of patch
> submission protocols.  Apologies up front for the newbie questions - i
> wasn't able to find anything relevant on the lists or apache developer
> info pages.
>
> 1. Are dependent patches ok?  For example i have some new integration
> tests that demonstrate issues, but part of that work was just setting
> up the infrastructure to run integration tests in tapestry-hibernate.
> I figure that part would be useful on its own (particularly if the
> tests turn out not to be).  The patches for the tests would then
> depend on the infrastructure patch.

Can you wait for the first patch to be applied before providing the second?

>
> 2. I use 'git' to manage work locally, among other reasons because it
> simplifies maintaining multiple patches against an active stream.  The
> patches git generates are slightly different from those generated by
> 'svn diff'.  They do apply cleanly when fed into a regular GNU 'patch'
> command, but i don't know if there are other concerns.  A quick search
> didn't yield any tools to convert a git patch into one that looks
> identical to an svn one, but i can look harder (or massage them
> manually) if need be.  If your process is to apply submissions onto a
> working copy via 'patch' then i don't anticipate any trouble, but
> please let me know.

Hopefully IntellIJ can understand this format.


>
> Thank you,
> lasitha.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
> For additional commands, e-mail: dev-help@tapestry.apache.org
>
>



-- 
Howard M. Lewis Ship
Partner and Senior Architect at Feature50

Creator Apache Tapestry and Apache HiveMind

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org