You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/29 18:56:05 UTC

[GitHub] [pulsar] poorbarcode opened a new pull request, #17893: [fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled

poorbarcode opened a new pull request, #17893:
URL: https://github.com/apache/pulsar/pull/17893

   Fixes
   
   -  #16864
   
   ### Motivation
   
   The process expect:
   
   - send 30 messages in one batch
   - receive 30 messages, do negative acknowledge
     - push the `batched-messageId` to `negativeAcksTracker`
     - push the `batched-messageId` to `unAckedMessageTracker`
   - after `1s`, will trigger `redelivery messages which have not acknowledged`
   - receive 30 messages again
   
   The real process:
   - send 1 message in one batch
   - send 29 messages in another batch
   - <strong>(High light)</strong> then there has two `batched-message`, aka `msgId_1` & `msgId_2`
   - receive 29 messages, do negative acknowledge
     - push the `msgId_1` to `negativeAcksTracker`
     - push the `msgId_2` to `unAckedMessageTracker`
   - after `1s`, will trigger redelivery `msgId_2`
   - receive 29 messages( `msgId_2` ) again
   - after `60s`, will trigger redelivery `msgId_2`. <strong>(High light)</strong> Test execution timeout!
   - receive 1 messages( `msgId_1` ) again
   
   ### Modifications
   
   - set negativeAckRedeliveryDelay to `2s`
   - set timeout limit to `15s`
   
   ### Documentation
   
   - [x] `doc-not-needed` 
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   
   - https://github.com/poorbarcode/pulsar/pull/18


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] congbobo184 merged pull request #17893: [fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled

Posted by GitBox <gi...@apache.org>.
congbobo184 merged PR #17893:
URL: https://github.com/apache/pulsar/pull/17893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui closed pull request #17893: [fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled

Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17893: [fix][flaky-test]NegativeAcksTest.testNegativeAcksWithBatchAckEnabled
URL: https://github.com/apache/pulsar/pull/17893


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org