You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2013/10/30 23:03:02 UTC

[jclouds] Enable RedundantModifier for Checkstyle (#193)

You can merge this Pull Request by running:

  git pull https://github.com/maginatics/jclouds checkstyle-redundant-modifier

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/193

-- Commit Summary --

  * Enable RedundantModifier for Checkstyle

-- File Changes --

    M apis/atmos/src/main/java/org/jclouds/atmos/domain/MutableContentMetadata.java (12)
    M apis/cloudstack/src/main/java/org/jclouds/cloudstack/functions/StaticNATVirtualMachineInNetwork.java (2)
    M apis/ec2/src/main/java/org/jclouds/ec2/domain/Subnet.java (2)
    M apis/ec2/src/main/java/org/jclouds/ec2/domain/Tag.java (2)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/suppliers/LocationIdToURIFromAccessForTypeAndVersion.java (2)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/suppliers/RegionIdToAdminURISupplier.java (2)
    M apis/openstack-keystone/src/test/java/org/jclouds/openstack/keystone/v2_0/config/ProviderModuleExpectTest.java (2)
    M apis/openstack-keystone/src/test/java/org/jclouds/openstack/v2_0/functions/PresentWhenExtensionAnnotationNamespaceEqualsAnyNamespaceInExtensionsSetTest.java (6)
    M apis/rackspace-cloudloadbalancers/src/main/java/org/jclouds/rackspace/cloudloadbalancers/v1/functions/ConvertLB.java (2)
    M apis/s3/src/main/java/org/jclouds/s3/S3AsyncClient.java (4)
    M apis/s3/src/main/java/org/jclouds/s3/S3Client.java (2)
    M apis/s3/src/main/java/org/jclouds/s3/domain/AccessControlList.java (2)
    M apis/sqs/src/test/java/org/jclouds/sqs/features/PermissionApiLiveTest.java (4)
    M common/openstack/src/main/java/org/jclouds/openstack/functions/URIFromAuthenticationResponseForService.java (2)
    M common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/suppliers/V1DefaultRegionIdSupplier.java (2)
    M compute/src/main/java/org/jclouds/compute/callables/BlockUntilInitScriptStatusIsZeroThenReturnOutput.java (2)
    M compute/src/main/java/org/jclouds/compute/config/BaseComputeServiceContextModule.java (2)
    M compute/src/main/java/org/jclouds/compute/domain/CloneImageTemplate.java (2)
    M compute/src/main/java/org/jclouds/compute/domain/ComputeMetadata.java (10)
    M compute/src/main/java/org/jclouds/compute/domain/ComputeMetadataIncludingStatus.java (4)
    M compute/src/main/java/org/jclouds/compute/domain/ImageTemplate.java (2)
    M compute/src/main/java/org/jclouds/compute/domain/TemplateBuilder.java (2)
    M compute/src/main/java/org/jclouds/compute/domain/TemplateBuilderSpec.java (2)
    M compute/src/main/java/org/jclouds/compute/functions/GroupNamingConvention.java (2)
    M compute/src/main/java/org/jclouds/compute/functions/Sha512Crypt.java (2)
    M compute/src/main/java/org/jclouds/compute/strategy/CustomizeNodeAndAddToGoodMapOrPutExceptionIntoBadMap.java (2)
    M core/src/main/java/org/jclouds/apis/ApiMetadata.java (2)
    M core/src/main/java/org/jclouds/date/DateCodec.java (4)
    M core/src/main/java/org/jclouds/http/functions/ParseSax.java (2)
    M core/src/main/java/org/jclouds/io/ContentMetadataCodec.java (6)
    M core/src/main/java/org/jclouds/json/config/GsonModule.java (2)
    M core/src/main/java/org/jclouds/location/suppliers/RegionIdToURISupplier.java (2)
    M core/src/main/java/org/jclouds/location/suppliers/ZoneIdToURISupplier.java (2)
    M core/src/main/java/org/jclouds/logging/Logger.java (2)
    M core/src/main/java/org/jclouds/providers/ProviderMetadata.java (10)
    M core/src/main/java/org/jclouds/rest/HttpApiMetadata.java (2)
    M core/src/main/java/org/jclouds/rest/RestApiMetadata.java (2)
    M core/src/main/java/org/jclouds/rest/binders/BindToJsonPayloadWrappedWith.java (2)
    M core/src/main/java/org/jclouds/xml/XMLParser.java (8)
    M core/src/test/java/org/jclouds/rest/InputParamValidatorTest.java (4)
    M core/src/test/java/org/jclouds/rest/annotationparsing/ClosableApiTest.java (4)
    M core/src/test/java/org/jclouds/rest/annotationparsing/DelegateAnnotationExpectTest.java (8)
    M core/src/test/java/org/jclouds/rest/annotationparsing/ProvidesAnnotationExpectTest.java (4)
    M core/src/test/java/org/jclouds/rest/binders/BindMapToStringPayloadTest.java (2)
    M core/src/test/java/org/jclouds/rest/config/MappedHttpInvocationModuleTest.java (8)
    M core/src/test/java/org/jclouds/rest/config/ReadAnnotationsAndPropertiesTest.java (4)
    M core/src/test/java/org/jclouds/rest/functions/PresentWhenApiVersionLexicographicallyAtOrAfterSinceApiVersionTest.java (8)
    M core/src/test/java/org/jclouds/rest/internal/InvokeHttpMethodTest.java (2)
    M core/src/test/java/org/jclouds/rest/internal/InvokeMappedHttpMethodTest.java (4)
    M core/src/test/java/org/jclouds/rest/internal/RestAnnotationProcessorTest.java (16)
    M core/src/test/java/org/jclouds/util/Optionals2Test.java (2)
    M drivers/jsch/src/main/java/org/jclouds/ssh/jsch/JschSshClient.java (4)
    M drivers/sshj/src/main/java/org/jclouds/sshj/SshjSshClient.java (2)
    M providers/azureblob/src/main/java/org/jclouds/azureblob/AzureBlobAsyncClient.java (2)
    M providers/azureblob/src/main/java/org/jclouds/azureblob/AzureBlobClient.java (2)
    M resources/checkstyle.xml (4)
    M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/functionloader/FunctionLoader.java (2)
    M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/login/AdminAccess.java (2)
    M scriptbuilder/src/main/java/org/jclouds/scriptbuilder/statements/login/AdminAccessBuilderSpec.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/193.patch
https://github.com/jclouds/jclouds/pull/193.diff

Re: [jclouds] Enable RedundantModifier for Checkstyle (#193)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-pull-requests #358](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/358/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/193#issuecomment-27445007

Re: [jclouds] Enable RedundantModifier for Checkstyle (#193)

Posted by Andrew Gaul <no...@github.com>.

Pushed to master.

@nacx other repositories violate Checkstyle for a variety of reasons today.  jclouds-labs-google uses the correct config but has many violations.  jclouds-karaf uses the incorrect config.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/193#issuecomment-27507441

Re: [jclouds] Enable RedundantModifier for Checkstyle (#193)

Posted by Ignasi Barrera <no...@github.com>.

Cool! :) Once this is merged, are you going to open the corresponding PRs in the other repos?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/193#issuecomment-27444226

Re: [jclouds] Enable RedundantModifier for Checkstyle (#193)

Posted by CloudBees pull request builder plugin <no...@github.com>.

[jclouds-java-7-pull-requests #821](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/821/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/193#issuecomment-27445018