You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ra...@apache.org on 2025/09/02 12:12:22 UTC

(arrow) branch main updated: GH-47440: [C++] Accept gflags::gflags as system gflags CMake target (#47468)

This is an automated email from the ASF dual-hosted git repository.

raulcd pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 427caf0e7d GH-47440: [C++] Accept gflags::gflags as system gflags CMake target (#47468)
427caf0e7d is described below

commit 427caf0e7d5d65928d26ce964e7dea4073008886
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Tue Sep 2 21:12:15 2025 +0900

    GH-47440: [C++] Accept gflags::gflags as system gflags CMake target (#47468)
    
    ### Rationale for this change
    
    MSYS2's gflags package always uses `gflags::gflags` not `gflags::gflags_shared`.
    
    ### What changes are included in this PR?
    
    Check `gflags::gflags`.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    Yes.
    * GitHub Issue: #47440
    
    Authored-by: Sutou Kouhei <ko...@clear-code.com>
    Signed-off-by: Raúl Cumplido <ra...@gmail.com>
---
 cpp/cmake_modules/ThirdpartyToolchain.cmake | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 6e7544a707..acd7f42a06 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1723,6 +1723,8 @@ if(ARROW_NEED_GFLAGS)
       set(GFLAGS_LIBRARIES gflags-shared)
     elseif(TARGET gflags_shared)
       set(GFLAGS_LIBRARIES gflags_shared)
+    elseif(TARGET gflags::gflags)
+      set(GFLAGS_LIBRARIES gflags::gflags)
     endif()
   endif()
 endif()