[jira] [Resolved] (NET-528) FTPListParseEngine does not provide access to raw responses

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/NET-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved NET-528.
----------------------
       Resolution: Fixed
    Fix Version/s: 3.4

URL: http://svn.apache.org/r1644802
Log:
NET-528 FTPListParseEngine does not provide access to raw responses

Added:
    commons/proper/net/trunk/src/main/java/examples/telnet/TelnetClientScript.java
Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/examples/ftp/FTPClientExample.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClientConfig.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPFile.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java
    commons/proper/net/trunk/src/test/java/org/apache/commons/net/ftp/FTPClientTest.java

Note: TelnetClientScript was added by mistake; not part of the issue

> FTPListParseEngine does not provide access to raw responses
> -----------------------------------------------------------
>
>                 Key: NET-528
>                 URL: https://issues.apache.org/jira/browse/NET-528
>             Project: Commons Net
>          Issue Type: Improvement
>            Reporter: Sebb
>             Fix For: 3.4
>
>
> The FTPListParseEngine class reads the responses from the server and stores the lines in a list during the preparse phase.
> The parse phase creates the FTPFile entries from the raw strings. However, if parsing fails, nothing is returned. There is currently no way to access the unparsed string that failed the parsing.
> It would be useful to provide this access somehow.
> The FTPFile class does include the unparsed entry as one of its fields.
> However, currently the expectation is that only parsed entries will be returned, so it would be necessary to add a configuration option for the engine. This would probably need to be an FTPClient option that could be passed to the engine on construction or perhaps as a getFiles() parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)