You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2013/05/29 02:22:20 UTC

[jira] [Commented] (HBASE-8634) Fix potential null pointer dereference in HRegionServer and TableLockChecker

    [ https://issues.apache.org/jira/browse/HBASE-8634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668839#comment-13668839 ] 

Hadoop QA commented on HBASE-8634:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12585107/8634-v1.txt
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop1.0{color}.  The patch compiles against the hadoop 1.0 profile.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestTableLockManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/5854//console

This message is automatically generated.
                
> Fix potential null pointer dereference in HRegionServer and TableLockChecker
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-8634
>                 URL: https://issues.apache.org/jira/browse/HBASE-8634
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: 8634-v1.txt
>
>
> From https://builds.apache.org/job/PreCommit-HBASE-Build/5852//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html :
> {code}
> <td>Possible null pointer dereference of rpcc in org.apache.hadoop.hbase.regionserver.HRegionServer.multi(RpcController, ClientProtos$MultiRequest)</td>
> </tr>
> <tr class="detailrow0">
> <td/>
> <td>
> <p id="N69637" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.regionserver.HRegionServer<br/>In method org.apache.hadoop.hbase.regionserver.HRegionServer.multi(RpcController, ClientProtos$MultiRequest)<br/>Value loaded from rpcc<br/>Dereferenced at HRegionServer.java:[line 3176]<br/>Known null at HRegionServer.java:[line 3174]</p>
> ...
> <td>Possible null pointer dereference of rpcc in org.apache.hadoop.hbase.regionserver.HRegionServer.mutate(RpcController, ClientProtos$MutateRequest)</td>
> </tr>
> <tr class="detailrow1">
> <td/>
> <td>
> <p id="N69712" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.regionserver.HRegionServer<br/>In method org.apache.hadoop.hbase.regionserver.HRegionServer.mutate(RpcController, ClientProtos$MutateRequest)<br/>Value loaded from rpcc<br/>Dereferenced at HRegionServer.java:[line 2832]<br/>Known null at HRegionServer.java:[line 2830]</p>
> ...
> <td>Possible null pointer dereference of rpcc in org.apache.hadoop.hbase.regionserver.HRegionServer.replay(RpcController, ClientProtos$MultiRequest)</td>
> </tr>
> <tr class="detailrow0">
> <td/>
> <td>
> <p id="N69787" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.regionserver.HRegionServer<br/>In method org.apache.hadoop.hbase.regionserver.HRegionServer.replay(RpcController, ClientProtos$MultiRequest)<br/>Value loaded from rpcc<br/>Dereferenced at HRegionServer.java:[line 3742]<br/>Known null at HRegionServer.java:[line 3740]</p>
> ...
> <td>Possible null pointer dereference of data in org.apache.hadoop.hbase.util.hbck.TableLockChecker$1.handleMetadata(byte[])</td>
> </tr>
> <tr class="detailrow1">
> <td/>
> <td>
> <p id="N73108" style="display: none;">
> <a href="#NP_NULL_ON_SOME_PATH">Bug type NP_NULL_ON_SOME_PATH (click for details)</a>
> <br/>In class org.apache.hadoop.hbase.util.hbck.TableLockChecker$1<br/>In method org.apache.hadoop.hbase.util.hbck.TableLockChecker$1.handleMetadata(byte[])<br/>Value loaded from data<br/>Dereferenced at TableLockChecker.java:[line 68]<br/>Known null at TableLockChecker.java:[line 60]</p>
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira