You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/10/07 05:52:53 UTC
[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core
apache-mynewt-bot removed a comment on pull request #872:
URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-704705096
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### porting/nimble/include/os/os_mbuf.h
<details>
```diff
@@ -428,7 +428,7 @@
uint16_t os_mbuf_len(const struct os_mbuf *om);
/**
-/**
+ /**
* Append data onto a mbuf
*
* @param om The mbuf to append the data onto
@@ -645,7 +645,7 @@
int os_mbuf_widen(struct os_mbuf *om, uint16_t off, uint16_t len);
/**
-/**
+ /**
* Creates a single chained mbuf from m1 and m2 utilizing all
* the available buffer space in all mbufs in the resulting
* chain. In other words, ensures there is no leading space in
```
</details>
#### porting/nimble/src/hal_timer.c
<details>
```diff
@@ -367,7 +367,7 @@
rtctimer = (NRF_RTC_Type *)bsptimer->tmr_reg;
compare = rtctimer->EVENTS_COMPARE[NRF_RTC_TIMER_CC_INT];
if (compare) {
- rtctimer->EVENTS_COMPARE[NRF_RTC_TIMER_CC_INT] = 0;
+ rtctimer->EVENTS_COMPARE[NRF_RTC_TIMER_CC_INT] = 0;
}
tick = rtctimer->EVENTS_TICK;
```
</details>
#### porting/nimble/src/os_mempool.c
<details>
```diff
@@ -31,8 +31,8 @@
#if MYNEWT_VAL(OS_MEMPOOL_GUARD)
#define OS_MEMPOOL_TRUE_BLOCK_SIZE(mp) \
(((mp)->mp_flags & OS_MEMPOOL_F_EXT) ? \
- OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size) : \
- (OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size) + sizeof(os_membuf_t)))
+ OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size) : \
+ (OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size) + sizeof(os_membuf_t)))
#else
#define OS_MEMPOOL_TRUE_BLOCK_SIZE(mp) OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size)
#endif
@@ -94,7 +94,7 @@
if ((mp->mp_flags & OS_MEMPOOL_F_EXT) == 0) {
tgt = (uint32_t *)((uintptr_t)start +
- OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size));
+ OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size));
*tgt = OS_MEMPOOL_GUARD_PATTERN;
}
}
@@ -106,7 +106,7 @@
if ((mp->mp_flags & OS_MEMPOOL_F_EXT) == 0) {
tgt = (uint32_t *)((uintptr_t)start +
- OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size));
+ OS_MEM_TRUE_BLOCK_SIZE(mp->mp_block_size));
assert(*tgt == OS_MEMPOOL_GUARD_PATTERN);
}
}
```
</details>
#### porting/nimble/src/os_msys_init.c
<details>
```diff
@@ -119,8 +119,8 @@
struct os_mbuf_pool *pool;
/* If dsize = 0 that means user has no idea how big block size is needed,
- * therefore lets find for him the biggest one
- */
+ * therefore lets find for him the biggest one
+ */
if (dsize == 0) {
pool = os_msys_find_biggest_pool();
} else {
@@ -144,7 +144,7 @@
struct os_mbuf *m;
struct os_mbuf_pool *pool;
- total_pkthdr_len = user_hdr_len + sizeof(struct os_mbuf_pkthdr);
+ total_pkthdr_len = user_hdr_len + sizeof(struct os_mbuf_pkthdr);
/* If dsize = 0 that means user has no idea how big block size is needed,
* therefore lets find for him the biggest one
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org