[GitHub] [incubator-shardingsphere] tristaZero commented on a change in pull request #5158: delete predicateSegment from JoinSpecificationSegment

[GitBox <gi...@apache.org>]

tristaZero commented on a change in pull request #5158: delete predicateSegment from JoinSpecificationSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/5158#discussion_r407326050
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/SelectStatement.java
 ##########
 @@ -107,9 +107,19 @@
      */
     public Collection<SimpleTableSegment> getSimpleTableSegments() {
         Collection<SimpleTableSegment> result = new LinkedList<>();
+        Collection<SimpleTableSegment> tmp = new LinkedList<>();
         for (TableReferenceSegment each: tableReferences) {
             result.addAll(each.getSimpleTableSegments());
         }
+        for (SimpleTableSegment each: result) {
 
 Review comment:
   Maybe you need `a set` to remove duplicated ones? Or do you have anyother solution?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services