You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/09/18 14:06:34 UTC

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24888


Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................

IMPALA-15369: Check for the CRC32 extension at startup on ARM64

On aarch64, Impala is built with -march=armv8-a+crc, and native code
and codegen use CRC32 instructions for hashing (HashUtil::Hash(),
LlvmCodeGen::GetHashFunction()) without checking for them at runtime.
The CRC32 extension is optional in ARMv8.0, so on such CPUs the daemons
crash with SIGILL once a CRC32 code path runs, instead of failing at
startup with a clear message.

This change extends CpuInfo::EnforceCpuRequirements() to check the
HWCAP_CRC32 bit of the hardware capabilities reported by the kernel
(getauxval(AT_HWCAP)) on aarch64. All daemons already call it from
InitCommonRuntime() and exit with an error message if it fails, like
for the AVX/AVX2 requirement on x86_64.

Testing:
 - Core tests show no new errors on ARM machine

Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Assisted-by: Claude Opus 5 (Claude Code)
---
M be/src/util/cpu-info.cc
1 file changed, 14 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/24888/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 17:30:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14122/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 20:52:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2026 01:17:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24137/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 17:42:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24888/1/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

http://gerrit.cloudera.org:8080/#/c/24888/1/be/src/util/cpu-info.cc@275
PS1, Line 275: #elif defined(__aarch64__)
Is it possible to include CRC32 into the CpuInfo class, that way it would be in line with other CPU flag checks



-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Sep 2026 08:07:27 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 20:52:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Peter Rozsa, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24888

to look at the new patch set (#2).

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................

IMPALA-15369: Check for the CRC32 extension at startup on ARM64

On aarch64, Impala is built with -march=armv8-a+crc, and native code
and codegen use CRC32 instructions for hashing (HashUtil::Hash(),
LlvmCodeGen::GetHashFunction()) without checking for them at runtime.
The CRC32 extension is optional in ARMv8.0, so on such CPUs the daemons
crash with SIGILL once a CRC32 code path runs, instead of failing at
startup with a clear message.

This change adds a CpuInfo::CRC32 hardware flag. CpuInfo::Init() now
also parses the 'Features' line of /proc/cpuinfo, which is where the
kernel lists the CPU features on aarch64 (x86_64 uses 'flags').
CpuInfo::EnforceCpuRequirements() fails on aarch64 if CRC32 is not
supported. All daemons already call it from InitCommonRuntime() and
exit with an error message if it fails, like for the AVX/AVX2
requirement on x86_64.

Testing:
 - Core tests show no new errors on ARM machine

Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
2 files changed, 17 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/24888/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................

IMPALA-15369: Check for the CRC32 extension at startup on ARM64

On aarch64, Impala is built with -march=armv8-a+crc, and native code
and codegen use CRC32 instructions for hashing (HashUtil::Hash(),
LlvmCodeGen::GetHashFunction()) without checking for them at runtime.
The CRC32 extension is optional in ARMv8.0, so on such CPUs the daemons
crash with SIGILL once a CRC32 code path runs, instead of failing at
startup with a clear message.

This change adds a CpuInfo::CRC32 hardware flag. CpuInfo::Init() now
also parses the 'Features' line of /proc/cpuinfo, which is where the
kernel lists the CPU features on aarch64 (x86_64 uses 'flags').
CpuInfo::EnforceCpuRequirements() fails on aarch64 if CRC32 is not
supported. All daemons already call it from InitCommonRuntime() and
exit with an error message if it fails, like for the AVX/AVX2
requirement on x86_64.

Testing:
 - Core tests show no new errors on ARM machine

Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Assisted-by: Claude Opus 5.5 (Claude Code)
Reviewed-on: http://gerrit.cloudera.org:8080/24888
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/cpu-info.cc
M be/src/util/cpu-info.h
2 files changed, 17 insertions(+), 4 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/24088/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2026 14:29:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 20:33:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 2:

(1 comment)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/24888/1/be/src/util/cpu-info.cc
File be/src/util/cpu-info.cc:

http://gerrit.cloudera.org:8080/#/c/24888/1/be/src/util/cpu-info.cc@275
PS1, Line 275: #elif defined(__aarch64__)
> Is it possible to include CRC32 into the CpuInfo class, that way it would b
Added it to CpuInfo, turns out we can still use /proc/cpuinfo as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Sep 2026 17:24:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-15369: Check for the CRC32 extension at startup on ARM64

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24888 )

Change subject: IMPALA-15369: Check for the CRC32 extension at startup on ARM64
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24888
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic01f8f8009e6e2d8dbfd324d83353b0d4dbf1d4c
Gerrit-Change-Number: 24888
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2026 16:20:00 +0000
Gerrit-HasComments: No