You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beam.apache.org by Ahmet Altay <al...@google.com> on 2022/05/04 16:20:24 UTC

Re: Sharing Go SDK Pre-Commit Improvements

Thank you Jack, this is a great improvement to code health :)

On Fri, Apr 29, 2022 at 2:21 PM Robert Burke <ro...@frantil.com> wrote:

> Woohoo 🎉!
>
> Thanks Jack for making it easier to maintain good Code Health and style
> for the Go SDK.
>
> Robert B
> Beam Go Busybody
>
> On Fri, Apr 29, 2022, 1:08 PM Jack McCluskey <jr...@google.com>
> wrote:
>
>> Hey everyone,
>>
>> I'm excited to share that the Beam Go SDK has added the Staticcheck
>> linter (https://staticcheck.io/) as a pre-commit GitHub Action! This, in
>> addition to the Go Vet and Go formatting checks we added to our pre-commit
>> suite earlier this year, helps us automatically catch common errors and
>> potential problems on every PR before they are merged. I'm extremely proud
>> of these additions as they took a significant amount of work over time to
>> make the existing code base compliant before adding the checks (see
>> BEAM-10206 <https://issues.apache.org/jira/browse/BEAM-10206> for vet
>> cleanups and BEAM-14240
>> <https://issues.apache.org/jira/browse/BEAM-14240> for the staticcheck
>> cleanups.)
>>
>> These pre-commits, along with an ongoing effort to improve unit test
>> coverage of the Go SDK (BEAM-13866
>> <https://issues.apache.org/jira/browse/BEAM-13866>,) are great for
>> increasing our confidence in the code base moving forward. I'm excited to
>> see the Go SDK continue to develop and grow over time!
>>
>> Thanks,
>>
>> Jack McCluskey
>> --
>>
>>
>> Jack McCluskey
>> SWE - DataPLS PLAT/ Beam Go
>> RDU
>> jrmccluskey@gmail.com
>>
>>
>>