[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #17500: support is null or is not null on right

[GitBox <gi...@apache.org>]

strongduanmu commented on code in PR #17500:
URL: https://github.com/apache/shardingsphere/pull/17500#discussion_r869023979


##########
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java:
##########
@@ -109,6 +110,9 @@ private void addEncryptConditions(final Collection<EncryptCondition> encryptCond
     
     private void addEncryptConditions(final Collection<EncryptCondition> encryptConditions, final ExpressionSegment expression, final Map<String, String> expressionTableNames) {
         for (ColumnSegment each : ColumnExtractor.extract(expression)) {
+            if (nullOnRight(expression)) {

Review Comment:
   Why add this check logic?



##########
shardingsphere-features/shardingsphere-encrypt/shardingsphere-encrypt-core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java:
##########
@@ -149,6 +153,17 @@ private Optional<EncryptCondition> createCompareEncryptCondition(final String ta
                 : Optional.empty();
     }
     
+    private boolean nullOnRight(final ExpressionSegment expression) {

Review Comment:
   Can we change this method name to a more meaningful one?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org