You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Vrushali C (JIRA)" <ji...@apache.org> on 2016/10/27 22:18:58 UTC

[jira] [Commented] (YARN-4675) Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl

    [ https://issues.apache.org/jira/browse/YARN-4675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15613444#comment-15613444 ] 

Vrushali C commented on YARN-4675:
----------------------------------

Looked at this as part of the yarn meetup #4. I also discussed with [~sjlee0]. 

In the next weekly call, I think we should think over this and decide whether or not we should go ahead with this, sooner rather than later. This should be done before 3.0 alpha is released, if we want this. I believe if we do this refactoring, Tez will have to re-code it's client calls, which is fine now but won't be so once 3.0 is released.

My thoughts are that this will make it cleaner to have separate client classes like the patch has. So I am +1 on reorganizing the TimeClientImpl into V1 and V2.

 

> Reorganize TimeClientImpl into TimeClientV1Impl and TimeClientV2Impl
> --------------------------------------------------------------------
>
>                 Key: YARN-4675
>                 URL: https://issues.apache.org/jira/browse/YARN-4675
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>              Labels: YARN-5355, oct16-medium
>         Attachments: YARN-4675-YARN-2928.v1.001.patch
>
>
> We need to reorganize TimeClientImpl into TimeClientV1Impl ,  TimeClientV2Impl and if required a base class, so that its clear which part of the code belongs to which version and thus better maintainable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org