You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Kevin Ross (JIRA)" <ji...@apache.org> on 2008/03/29 16:05:33 UTC
[jira] Created: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
--------------------------------------------------------------------------------------
Key: CAMEL-412
URL: https://issues.apache.org/activemq/browse/CAMEL-412
Project: Apache Camel
Issue Type: Bug
Environment: OSX
Reporter: Kevin Ross
Fix For: 1.3.0
Attachments: DotMojo.java.patch
Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
#. removed the default.
#. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan resolved CAMEL-412.
----------------------------------
Resolution: Fixed
To show this in use I've disabled the dot invocation in examples/camel-example-spring-xquery
{code}
<reporting>
<plugins>
<plugin>
<groupId>org.apache.camel</groupId>
<artifactId>camel-maven-plugin</artifactId>
<configuration>
<useDot>false</useDot>
</configuration>
</plugin>
</plugins>
</reporting>
{code}
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42316#action_42316 ]
Claus Ibsen commented on CAMEL-412:
-----------------------------------
Kevin have you seen the option to setup the executable at http://activemq.apache.org/camel/camel-dot-maven-goal.html
where you can configure the DOT.exe to use (on windows).
And if patch is meant to be include then please provide a patch that doesn't change the current code style in Camel.
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Kevin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Ross updated CAMEL-412:
-----------------------------
Attachment: DotMojo.java.patch
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Environment: OSX
> Reporter: Kevin Ross
> Fix For: 1.3.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42604#action_42604 ]
Claus Ibsen commented on CAMEL-412:
-----------------------------------
I updated the wiki with James example
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-412:
---------------------------------
Assignee: Claus Ibsen
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42335#action_42335 ]
Claus Ibsen commented on CAMEL-412:
-----------------------------------
James / Kevin
How do you actually configued the new option useDot to eg set it to false?
I am not a super maven wizard and have tried with
mvn camel:dot
Is what I used to start it
-DuseDot=false
<useDot>false</useDot> in the pom.xml in the configuration tag.
But neither fails.
Also in the source code
runCamelEmbedded()
it has hardcoded useDot to true
mojo.setDotEnabled(true);
Shouldn't it honor the useDot option instead so it should be
mojo.setDotEnabled(useDot);
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-412:
------------------------------
Fix Version/s: 1.4.0
(was: 1.3.0)
Affects Version/s: 1.2.0
1.3.0
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-412 started by Claus Ibsen.
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Assignee: Claus Ibsen
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=41932#action_41932 ]
James Strachan commented on CAMEL-412:
--------------------------------------
I've applied half of your patch - that if the executable property is empty or null then the generation is skipped.
BTW its maybe an idea not to reformat the code before sending patches in the future, its kinda hard to see what you really did :)
I'm not sure if we should remove the default executable name for DOT. Its up to users to use the plugin or not - you can also use [maven profiles|http://maven.apache.org/guides/introduction/introduction-to-profiles.html] to only enable the plugin if its activated and so forth. So I like the idea of the plugin invoking "dot" on the path by default (as thats gonna work on most OSes).
Maybe to disable the use of dot we can just use another property? I've added a useDot property so folks can disable the running of dot - would that do the trick?
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-412) OSX mvn -e -o
org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
Posted by "Kevin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=42323#action_42323 ]
Kevin Ross commented on CAMEL-412:
----------------------------------
Claus, I'm aware of how to set the executable, I mention this in the description of the issue. I don't want it to execute any dot program, I just want the dot file to be generated so that I can view in Graphviz for Mac. It will automatically render for me when I choose to view it.
I think James has the right idea. If the doc page you referenced were updated to reflect the additional that James made, this could be resolved without further work or application of the patch.
> OSX mvn -e -o org.apache.camel:camel-maven-plugin:dot fails due to the lack of dot.exe
> --------------------------------------------------------------------------------------
>
> Key: CAMEL-412
> URL: https://issues.apache.org/activemq/browse/CAMEL-412
> Project: Apache Camel
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0
> Environment: OSX
> Reporter: Kevin Ross
> Fix For: 1.4.0
>
> Attachments: DotMojo.java.patch
>
>
> Though the intent seemed to be there, the DotMojo does not skip conversion of the file if there is no value for <executable/> in the pom.xml. The parameter was defaulted.
> #. removed the default.
> #. added log message.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.