You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/04/05 19:12:55 UTC

Review Request 66478: ATLAS-2534: Atlas glossary support

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-2534
    https://issues.apache.org/jira/browse/ATLAS-2534


Repository: atlas


Description
-------

Glossary implementation, no UI


Diffs
-----

  addons/models/0000-Area0/0010-base_model.json aebe955db 
  addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfdf 
  addons/models/0300-Area3-SubjectArea/0350-RelatedTerms.json d88f57c20 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
  intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
  intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
  repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
  repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
  repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
  webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66478/diff/1/


Testing
-------

Added test GlossaryServiceTest, runs successfully.

mvn clean package executes successfully.

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/234/ (in-progress)


Thanks,

Apoorv Naik

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Apoorv Naik <na...@gmail.com>.


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java
> > Lines 144 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993066#file1993066line144>
> >
> >     why create a new HashSet, instead of adding to exiting one?
> >     
> >       Set<AtlasRelatedTermId> terms = this.terms;
> >     
> >       if (terms == null) {
> >         terms = new HashSet<>();
> >     
> >         this.terms = terms;
> >       }
> >     
> >       terms.add(relatedTermId);
> >     
> >     Same for categories and classifications.

Will update the code


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
> > Lines 312 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993069#file1993069line312>
> >
> >     'examples' attribute is not handled by setAttribute()?

setAttribute is only called from the REST layer, and is used for partial updates of Primitive attributes only.


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java
> > Lines 36 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993073#file1993073line36>
> >
> >     is this the guid for: relationship or category? Consider renaming to categoryGuid or relationshipGuid.

Sure


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java
> > Lines 39 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993074#file1993074line39>
> >
> >     is this the guid for: relationship or term? Consider renaming to termGuid or relationshipGuid.

Sure.


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
> > Lines 87 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993075#file1993075line87>
> >
> >     Instead of using AtlasGlossaryTerm (which has references to all entities the term is assigned to, all terms the term is related to), consider using AtlasRelatedTermId (or an equivalent).

Will update.


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
> > Lines 120 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993086#file1993086line120>
> >
> >     not handling relationship attributes here? from() method above handles relationship attributes.

Setting relationship attributes causes the store to error out when handling them, hence they're only handled during the conversion from entity to POJO.


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
> > Lines 135 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993086#file1993086line135>
> >
> >     Shouldn't extInfo not include all entities referenced by relationship attributes?

Same as above


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
> > Lines 97 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993087#file1993087line97>
> >
> >     Consider adding toRelatedTermIdsSet() method and replace lines #96-#250 with:
> >       ret.setSeeAlso(toRelatedTermIdsSet(entity.getRelationshipAttribute("seeAlso")));
> >       ret.setSynonyms(toRelatedTermIdsSet(entity.getRelationshipAttribute("synonyms")));
> >       ret.setAntonyms(toRelatedTermIdsSet(entity.getRelationshipAttribute("antonyms")));
> >       ret.setPreferredTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("preferredTerms")));
> >       ret.setPreferredToTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("preferredToTerms")));
> >       ret.setReplacementTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("replacementTerms")));
> >       ret.setReplacedBy(toRelatedTermIdsSet(entity.getRelationshipAttribute("replacedBy")));
> >       ret.setTranslationTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("translationTerms")));
> >       ret.setTranslatedTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("translatedTerms")));
> >       ret.setIsA(toRelatedTermIdsSet(entity.getRelationshipAttribute("isA")));
> >       ret.setClassify(toRelatedTermIdsSet(entity.getRelationshipAttribute("classify")));
> >       ret.setValidValues(toRelatedTermIdsSet(entity.getRelationshipAttribute("validValues")));
> >       ret.setValidValuesFor(toRelatedTermIdsSet(entity.getRelationshipAttribute("validValuesFor")));
> >     
> >     
> >     
> >     
> >     
> >     Set<AtlasRelatedTermId> toRelatedTermIdsSet(Object obj) {
> >       Set<AtlasRelatedTermId> ret = null;
> >     
> >       if (obj instanceof Collection) {
> >         ret = new HashSet<>();
> >     
> >         for (Object elem : (Collection) obj) {
> >           if (elem instanceof AtlasRelatedObjectId) {
> >             ret.add(toRelatedTermId((AtlasRelatedObjectId) elem);
> >           }
> >         }
> >       }
> >       
> >       return ret;
> >     }

Will update the implementation


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
> > Lines 286 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993087#file1993087line286>
> >
> >     not handling relationship attributes here?

Setting relationship attributes causes the store to error out when handling them, hence they're only handled during the conversion from entity to POJO.


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
> > Lines 302 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993087#file1993087line302>
> >
> >     Shouldn't extInfo not include all entities referenced by relationship attributes?

Same as above


> On April 5, 2018, 9:44 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
> > Lines 71 (patched)
> > <https://reviews.apache.org/r/66478/diff/1/?file=1993089#file1993089line71>
> >
> >     Consider using Constants.QUALIFIED_NAME, instead of introducing a new const.

Will do.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200563
-----------------------------------------------------------


On April 5, 2018, 8:10 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 8:10 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfdf 
>   addons/models/0300-Area3-SubjectArea/0350-RelatedTerms.json d88f57c20 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/2/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200563
-----------------------------------------------------------




addons/models/0000-Area0/0010-base_model.json
Lines 542 (patched)
<https://reviews.apache.org/r/66478/#comment281294>

    For consistency with other relationship types defined here, use prefix '__Atlas' for type names.



addons/models/0300-Area3-SubjectArea/0330-Terms.json
Line 71 (original), 71 (patched)
<https://reviews.apache.org/r/66478/#comment281295>

    Models under 0300-Area3-SubjectArea are being removed in Mandy's patch https://reviews.apache.org/r/66375/. Please revert changes to files deleted by Mandy's patch.



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java
Lines 47 (patched)
<https://reviews.apache.org/r/66478/#comment281296>

    Comment to be removed?



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java
Lines 144 (patched)
<https://reviews.apache.org/r/66478/#comment281297>

    why create a new HashSet, instead of adding to exiting one?
    
      Set<AtlasRelatedTermId> terms = this.terms;
    
      if (terms == null) {
        terms = new HashSet<>();
    
        this.terms = terms;
      }
    
      terms.add(relatedTermId);
    
    Same for categories and classifications.



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java
Lines 37 (patched)
<https://reviews.apache.org/r/66478/#comment281298>

    Consider moving the following attributes to AtlasGlossaryBaseObject (and remove from AtlasGlossary, AtlasGlossaryCategory, AtlasGlossaryTerm:
     - displayName
     - shortDescription
     - longDescription
     - classifications



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 312 (patched)
<https://reviews.apache.org/r/66478/#comment281299>

    'examples' attribute is not handled by setAttribute()?



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 367 (patched)
<https://reviews.apache.org/r/66478/#comment281300>

    "RelatedTerm" ==> "seeAlso"



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 383 (patched)
<https://reviews.apache.org/r/66478/#comment281301>

    "preferredTerm" ==> "preferredToTerm"



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 391 (patched)
<https://reviews.apache.org/r/66478/#comment281304>

    ReplacementTerm ==> replacedBy



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 407 (patched)
<https://reviews.apache.org/r/66478/#comment281303>

    IsARelationship ==> classifies



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Lines 415 (patched)
<https://reviews.apache.org/r/66478/#comment281302>

    validValue ==> validValueFor



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java
Lines 30 (patched)
<https://reviews.apache.org/r/66478/#comment281306>

    Is AtlasRelatedCategoryId only used in 'term to category' relationship?
    
    If not, AtlasTermRelationshipStatus doesn't seem to be intutive. Please review.



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java
Lines 36 (patched)
<https://reviews.apache.org/r/66478/#comment281305>

    is this the guid for: relationship or category? Consider renaming to categoryGuid or relationshipGuid.



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java
Lines 39 (patched)
<https://reviews.apache.org/r/66478/#comment281307>

    is this the guid for: relationship or term? Consider renaming to termGuid or relationshipGuid.



intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 87 (patched)
<https://reviews.apache.org/r/66478/#comment281308>

    Instead of using AtlasGlossaryTerm (which has references to all entities the term is assigned to, all terms the term is related to), consider using AtlasRelatedTermId (or an equivalent).



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
Lines 120 (patched)
<https://reviews.apache.org/r/66478/#comment281325>

    not handling relationship attributes here? from() method above handles relationship attributes.



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java
Lines 135 (patched)
<https://reviews.apache.org/r/66478/#comment281324>

    Shouldn't extInfo not include all entities referenced by relationship attributes?



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
Lines 97 (patched)
<https://reviews.apache.org/r/66478/#comment281321>

    Consider adding toRelatedTermIdsSet() method and replace lines #96-#250 with:
      ret.setSeeAlso(toRelatedTermIdsSet(entity.getRelationshipAttribute("seeAlso")));
      ret.setSynonyms(toRelatedTermIdsSet(entity.getRelationshipAttribute("synonyms")));
      ret.setAntonyms(toRelatedTermIdsSet(entity.getRelationshipAttribute("antonyms")));
      ret.setPreferredTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("preferredTerms")));
      ret.setPreferredToTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("preferredToTerms")));
      ret.setReplacementTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("replacementTerms")));
      ret.setReplacedBy(toRelatedTermIdsSet(entity.getRelationshipAttribute("replacedBy")));
      ret.setTranslationTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("translationTerms")));
      ret.setTranslatedTerms(toRelatedTermIdsSet(entity.getRelationshipAttribute("translatedTerms")));
      ret.setIsA(toRelatedTermIdsSet(entity.getRelationshipAttribute("isA")));
      ret.setClassify(toRelatedTermIdsSet(entity.getRelationshipAttribute("classify")));
      ret.setValidValues(toRelatedTermIdsSet(entity.getRelationshipAttribute("validValues")));
      ret.setValidValuesFor(toRelatedTermIdsSet(entity.getRelationshipAttribute("validValuesFor")));
    
    Set<AtlasRelatedTermId> toRelatedTermIdsSet(Object obj) {
      Set<AtlasRelatedTermId> ret = null;
    
      if (obj instanceof Collection) {
        ret = new HashSet<>();
    
        for (Object elem : (Collection) obj) {
          if (elem instanceof AtlasRelatedObjectId) {
            ret.add(toRelatedTermId((AtlasRelatedObjectId) elem);
          }
        }
      }
      
      return ret;
    }



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
Lines 286 (patched)
<https://reviews.apache.org/r/66478/#comment281323>

    not handling relationship attributes here?



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
Lines 302 (patched)
<https://reviews.apache.org/r/66478/#comment281322>

    Shouldn't extInfo not include all entities referenced by relationship attributes?



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
Lines 71 (patched)
<https://reviews.apache.org/r/66478/#comment281317>

    Consider using Constants.QUALIFIED_NAME, instead of introducing a new const.


- Madhan Neethiraj


On April 5, 2018, 8:10 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 8:10 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfdf 
>   addons/models/0300-Area3-SubjectArea/0350-RelatedTerms.json d88f57c20 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/2/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Apoorv Naik <na...@gmail.com>.


> On April 6, 2018, 5:49 p.m., Sarath Subramanian wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java
> > Lines 26 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993333#file1993333line26>
> >
> >     This class looks like a possible duplicate of AtlasRelatedCategoryId. Can't we reuse the same pojo?

The idea behind these id classes (more like entity header class) is to hide the internals of Atlas (relations etc) and model all Glossary related concepts as first class POJOs.


> On April 6, 2018, 5:49 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 396 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line396>
> >
> >     this delete relies on atlas.DeleteHandlerV1.impl for soft/hard delete. Shouldn't removal of glossary, terms, categories be always hard delete?

For now there's no way to enforce a hard delete for the glossary related entities. We can track this in another JIRA where the internal type deletion will always be hard delete, whereas the other ones can use the configured delete handler.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200657
-----------------------------------------------------------


On April 5, 2018, 11:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 11:57 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/4/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Sarath Subramanian <sa...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200657
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java
Lines 26 (patched)
<https://reviews.apache.org/r/66478/#comment281484>

    This class looks like a possible duplicate of AtlasRelatedCategoryId. Can't we reuse the same pojo?



intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Line 299 (original), 318 (patched)
<https://reviews.apache.org/r/66478/#comment281485>

    update init(), equals(), hashCode() and toString() to include 'meanings'



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 90 (patched)
<https://reviews.apache.org/r/66478/#comment281486>

    guidToLoad => guidsToLoad



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 140 (patched)
<https://reviews.apache.org/r/66478/#comment281487>

    throw valid atlas error code for invalid guids for glossary



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 396 (patched)
<https://reviews.apache.org/r/66478/#comment281488>

    this delete relies on atlas.DeleteHandlerV1.impl for soft/hard delete. Shouldn't removal of glossary, terms, categories be always hard delete?



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 404 (patched)
<https://reviews.apache.org/r/66478/#comment281490>

    method names can be more intuitive to know what type guid to supply:
    
    getGlossaryTerms      => getGlossaryTermsForGlossaryId
    getGlossaryCategories => getGlossaryCategoriesForGlossaryId
    getCategoryTerms      => getCategoryTermsForCategoryId
    getRelatedTerms       => getRelatedTermsForTermId
    getRelatedCategories  => getRelatedCategoriesForCategoryId


- Sarath Subramanian


On April 5, 2018, 4:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 4:57 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/4/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200693
-----------------------------------------------------------




addons/models/0000-Area0/0010-base_model.json
Line 2 (original), 2 (patched)
<https://reviews.apache.org/r/66478/#comment281544>

    This file has only white-space changes. Please revert.



addons/models/0000-Area0/0011-glossary_model.json
Lines 88 (patched)
<https://reviews.apache.org/r/66478/#comment281545>

    There is no unique attribute defined for entity types __AtlasGlossary, __AtlasGlossaryTerm and __AtlasGlossaryCategory. Consider adding 'qualifiedName' attribute with isUnique=true.



intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java
Lines 342 (patched)
<https://reviews.apache.org/r/66478/#comment281546>

    assignedTerms ==> meanings


- Madhan Neethiraj


On April 7, 2018, 12:48 a.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 7, 2018, 12:48 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   addons/models/0000-Area0/0011-glossary_model.json PRE-CREATION 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryHeader.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationHeader.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/5/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/236/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/
-----------------------------------------------------------

(Updated April 7, 2018, 12:48 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Added new REST endpoints for listing the assigned entities as well as assigning term to a list of entities.
Addressed review comments from David and Sarath

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/236/


Bugs: ATLAS-2534
    https://issues.apache.org/jira/browse/ATLAS-2534


Repository: atlas


Description
-------

Glossary implementation, no UI


Diffs (updated)
-----

  addons/models/0000-Area0/0010-base_model.json aebe955db 
  addons/models/0000-Area0/0011-glossary_model.json PRE-CREATION 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
  intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
  intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryHeader.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryHeader.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermHeader.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentHeader.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationHeader.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
  repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
  repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
  repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
  repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
  webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66478/diff/5/

Changes: https://reviews.apache.org/r/66478/diff/4-5/


Testing
-------

Added test GlossaryServiceTest, runs successfully.

mvn clean package executes successfully.

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)


Thanks,

Apoorv Naik

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200608
-----------------------------------------------------------




intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java
Lines 28 (patched)
<https://reviews.apache.org/r/66478/#comment281378>

    Update equals() and hashCode() for the addition of these attributes.



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java
Line 196 (original), 157 (patched)
<https://reviews.apache.org/r/66478/#comment281379>

    move displayName/shortDescription/longDescription/classification to the base class - in both equals() and hashCode().



intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java
Line 88 (original), 82 (patched)
<https://reviews.apache.org/r/66478/#comment281380>

    remove getClassification() and setClassification() - as they are already defined in base class.



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java
Line 27 (original), 26 (patched)
<https://reviews.apache.org/r/66478/#comment281382>

    Please include 'displayName' here, to avoid UI making additional REST API call to retrieve category details.



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java
Line 27 (original), 27 (patched)
<https://reviews.apache.org/r/66478/#comment281383>

    Please include 'displayName' here, to avoid UI making additional REST API call to retrieve category details.



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java
Line 97 (original), 97 (patched)
<https://reviews.apache.org/r/66478/#comment281386>

    A lot of repeatation here, to create Set<AtlasRelatedTermId> from Object - from #96 to #250. Please abstract the conversion into a method and call from here. It will make it easy to read and maintain.



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java
Lines 28 (patched)
<https://reviews.apache.org/r/66478/#comment281384>

    Please include 'displayName' here, to avoid UI making additional REST API call to retrieve category details.



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java
Lines 27 (patched)
<https://reviews.apache.org/r/66478/#comment281385>

    Please include 'displayName' here, to avoid UI making additional REST API call to retrieve category details.


- Madhan Neethiraj


On April 5, 2018, 11:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 11:57 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/4/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Apoorv Naik <na...@gmail.com>.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > addons/models/0000-Area0/0010-base_model.json
> > Lines 4 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993312#file1993312line4>
> >
> >     I suggest it would be cleaner to have the atlas glossary entiries and relationships in a new model file called atlasglossary.json.

That sounds like a good idea. I can look into making that change


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > addons/models/0000-Area0/0010-base_model.json
> > Line 105 (original), 180 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993312#file1993312line180>
> >
> >     You are subtyping __internal for the 3 new entities. Open metadata GlossaryTerm and the other glossary entities are actually referencables. I suggest subtypeing Referenceable to __internalReferencable and then using  __internalReferencable as the supertype for the 3 atlas entities you are adding. In this way you stay mappable to the open metadata types. I think the qualified name is important for these glossary entities.

Yes, internally the qualifiedName and guid requirement is enforced.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
> > Lines 132 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993320#file1993320line132>
> >
> >     I cannot see this being used - or what the text has to do with glossary

There's a partial update call for all 3 types, which can be used to update primitive attributes. This exception is to used in the partial update flow.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java
> > Lines 25 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993331#file1993331line25>
> >
> >     I am wondering why you need to introduce a new custom Atlas annotation

The JSON annotations are becoming repetitive across the intg module, idea is to use a meta annotation to control the JSON related features. Eventually all model classes will be annotated with this.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 576 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line576>
> >
> >     why can't they be empty?

For creating a relation between a glossary and term both the GUIDs need to be known. Similarly for any other relation in the Glossary domain, the guid of both ends should be available in order to create a relation.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 590 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line590>
> >
> >     Is this tracked by a Jira?

Not yet


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 602 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line602>
> >
> >     Unless it was created by the entity API and the relationship has not been created yet. I suggest the error mentions this - as the user would need to know this to be able to fix the issue.

Will add specialized errors for glossary, right now I was just using the generic bad request.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 618 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line618>
> >
> >     Unless it was created by the entity API and the relationship has not been created yet. I suggest the error mentions this - as the user would need to know this to be able to fix the issue.

Same as above


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 643 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line643>
> >
> >     Is the a Jira for this

Not yet


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 663 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line663>
> >
> >     Is there a Jira for this?

No, I'll be collectively addressing these relation related TODOs in one single glossary enhancement JIRA


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 678 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993337#file1993337line678>
> >
> >     I suspect you wanted to put some text here.

Good catch david.


> On April 6, 2018, 8:58 a.m., David Radley wrote:
> > repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java
> > Lines 18 (patched)
> > <https://reviews.apache.org/r/66478/diff/4/?file=1993344#file1993344line18>
> >
> >     what does the ogm package mean?

OGM notion is similar to ORM.


- Apoorv


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200630
-----------------------------------------------------------


On April 5, 2018, 11:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 11:57 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/4/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by David Radley <da...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/#review200630
-----------------------------------------------------------




addons/models/0000-Area0/0010-base_model.json
Lines 4 (patched)
<https://reviews.apache.org/r/66478/#comment281398>

    I suggest it would be cleaner to have the atlas glossary entiries and relationships in a new model file called atlasglossary.json.



addons/models/0000-Area0/0010-base_model.json
Line 105 (original), 180 (patched)
<https://reviews.apache.org/r/66478/#comment281399>

    You are subtyping __internal for the 3 new entities. Open metadata GlossaryTerm and the other glossary entities are actually referencables. I suggest subtypeing Referenceable to __internalReferencable and then using  __internalReferencable as the supertype for the 3 atlas entities you are adding. In this way you stay mappable to the open metadata types. I think the qualified name is important for these glossary entities.



intg/src/main/java/org/apache/atlas/AtlasErrorCode.java
Lines 132 (patched)
<https://reviews.apache.org/r/66478/#comment281400>

    I cannot see this being used - or what the text has to do with glossary



intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java
Lines 25 (patched)
<https://reviews.apache.org/r/66478/#comment281401>

    I am wondering why you need to introduce a new custom Atlas annotation



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 576 (patched)
<https://reviews.apache.org/r/66478/#comment281403>

    why can't they be empty?



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 590 (patched)
<https://reviews.apache.org/r/66478/#comment281402>

    Is this tracked by a Jira?



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 602 (patched)
<https://reviews.apache.org/r/66478/#comment281405>

    Unless it was created by the entity API and the relationship has not been created yet. I suggest the error mentions this - as the user would need to know this to be able to fix the issue.



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 618 (patched)
<https://reviews.apache.org/r/66478/#comment281404>

    Unless it was created by the entity API and the relationship has not been created yet. I suggest the error mentions this - as the user would need to know this to be able to fix the issue.



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 643 (patched)
<https://reviews.apache.org/r/66478/#comment281406>

    Is the a Jira for this



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 663 (patched)
<https://reviews.apache.org/r/66478/#comment281407>

    Is there a Jira for this?



repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 678 (patched)
<https://reviews.apache.org/r/66478/#comment281408>

    I suspect you wanted to put some text here.



repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java
Lines 18 (patched)
<https://reviews.apache.org/r/66478/#comment281409>

    what does the ogm package mean?


- David Radley


On April 5, 2018, 11:57 p.m., Apoorv Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66478/
> -----------------------------------------------------------
> 
> (Updated April 5, 2018, 11:57 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2534
>     https://issues.apache.org/jira/browse/ATLAS-2534
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Glossary implementation, no UI
> 
> 
> Diffs
> -----
> 
>   addons/models/0000-Area0/0010-base_model.json aebe955db 
>   graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
>   graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
>   graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
>   graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
>   intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
>   intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
>   repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
>   repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
>   repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
>   repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
>   repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
>   repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
>   repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
>   webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
>   webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66478/diff/4/
> 
> 
> Testing
> -------
> 
> Added test GlossaryServiceTest, runs successfully.
> 
> mvn clean package executes successfully.
> 
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)
> 
> 
> Thanks,
> 
> Apoorv Naik
> 
>

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/
-----------------------------------------------------------

(Updated April 5, 2018, 11:57 p.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Addressed review comments


Bugs: ATLAS-2534
    https://issues.apache.org/jira/browse/ATLAS-2534


Repository: atlas


Description
-------

Glossary implementation, no UI


Diffs (updated)
-----

  addons/models/0000-Area0/0010-base_model.json aebe955db 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
  intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
  intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermAssignmentId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasTermCategorizationId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
  repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
  repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
  repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
  repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java 8e19f79e8 
  webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66478/diff/3/

Changes: https://reviews.apache.org/r/66478/diff/2-3/


Testing
-------

Added test GlossaryServiceTest, runs successfully.

mvn clean package executes successfully.

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/235/ (in-progress)


Thanks,

Apoorv Naik

Re: Review Request 66478: ATLAS-2534: Atlas glossary support

Posted by Apoorv Naik <na...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66478/
-----------------------------------------------------------

(Updated April 5, 2018, 8:10 p.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, and Sarath Subramanian.


Changes
-------

Renamed term relations for consistency, added a DTO that was missing from patch.


Bugs: ATLAS-2534
    https://issues.apache.org/jira/browse/ATLAS-2534


Repository: atlas


Description
-------

Glossary implementation, no UI


Diffs (updated)
-----

  addons/models/0000-Area0/0010-base_model.json aebe955db 
  addons/models/0300-Area3-SubjectArea/0330-Terms.json f492ddfdf 
  addons/models/0300-Area3-SubjectArea/0350-RelatedTerms.json d88f57c20 
  graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java 7bdbeabf0 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/NativeTinkerpopGraphQuery.java 75665592e 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java 96b9705fa 
  graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/expr/OrderByPredicate.java PRE-CREATION 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java 6820a93c2 
  graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java d3c976df5 
  graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java 2903ae228 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 997ac68fb 
  intg/src/main/java/org/apache/atlas/model/AtlasBaseModelObject.java 688f6f4d2 
  intg/src/main/java/org/apache/atlas/model/annotation/AtlasJSON.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossary.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryBaseObject.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryCategory.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermAssignmentStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/enums/AtlasTermRelationshipStatus.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasGlossaryId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedCategoryId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/glossary/relations/AtlasRelatedTermId.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 395431922 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 576847f6e 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 61168f63f 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/AbstractDataTransferObject.java f1a8bc91d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasSavedSearchDTO.java a1a8f598d 
  repository/src/main/java/org/apache/atlas/repository/ogm/AtlasUserProfileDTO.java bcf2b9d27 
  repository/src/main/java/org/apache/atlas/repository/ogm/DTORegistry.java 818960d96 
  repository/src/main/java/org/apache/atlas/repository/ogm/DataAccess.java c99d2f836 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryCategoryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AtlasGlossaryTermDTO.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityChangeNotifier.java b9945d4fc 
  repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java 13ee2a6df 
  repository/src/main/java/org/apache/atlas/repository/userprofile/UserProfileService.java a428b92ee 
  repository/src/test/java/org/apache/atlas/TestModules.java c901e891c 
  repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/glossary/PaginationHelperTest.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/repository/impexp/ZipFileResourceTestUtils.java d8e916d77 
  webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java 01a95cf80 
  webapp/src/main/java/org/apache/atlas/web/rest/GlossaryREST.java PRE-CREATION 


Diff: https://reviews.apache.org/r/66478/diff/2/

Changes: https://reviews.apache.org/r/66478/diff/1-2/


Testing
-------

Added test GlossaryServiceTest, runs successfully.

mvn clean package executes successfully.

PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/234/ (in-progress)


Thanks,

Apoorv Naik