You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "Sn0rt (via GitHub)" <gi...@apache.org> on 2023/04/28 02:23:30 UTC

[GitHub] [apisix] Sn0rt opened a new pull request, #9389: ci: new test for lambda and proxy-rewrite work together

Sn0rt opened a new pull request, #9389:
URL: https://github.com/apache/apisix/pull/9389

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Fixes https://github.com/apache/apisix/issues/9351
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [x] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Sn0rt commented on pull request #9389: ci: new test for lambda and proxy-rewrite work together

Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt commented on PR #9389:
URL: https://github.com/apache/apisix/pull/9389#issuecomment-1535565838

   > Looks like we need documentation more than test cases
   
   now. this PR is not needed anymore. 
   I will implement a new feature that supports users removing the UA by proxy-rewrite. this PR need to keep pending status.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] soulbird commented on pull request #9389: ci: new test for lambda and proxy-rewrite work together

Posted by "soulbird (via GitHub)" <gi...@apache.org>.
soulbird commented on PR #9389:
URL: https://github.com/apache/apisix/pull/9389#issuecomment-1533976311

   Looks like we need documentation more than test cases


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Sn0rt closed pull request #9389: ci: new test for lambda and proxy-rewrite work together

Posted by "Sn0rt (via GitHub)" <gi...@apache.org>.
Sn0rt closed pull request #9389: ci: new test for lambda and proxy-rewrite work together
URL: https://github.com/apache/apisix/pull/9389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org