You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "dcapwell (via GitHub)" <gi...@apache.org> on 2023/02/02 17:57:50 UTC
[GitHub] [cassandra-accord] dcapwell commented on a diff in pull request #29: Cassandra 18204
dcapwell commented on code in PR #29:
URL: https://github.com/apache/cassandra-accord/pull/29#discussion_r1094885243
##########
accord-core/build.gradle:
##########
@@ -56,16 +56,39 @@ task testJar(type: Jar, dependsOn: testClasses) {
publishing {
publications {
mavenJava(MavenPublication) {
- artifactId = 'accord'
+ artifactId = accord_artifactId
pom {
+ name = 'Apache Cassandra Accord'
+ description = 'General purpose transactions library using a leaderless consensus protocol to have highly available transactions'
+ url = 'https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-15%3A+General+Purpose+Transactions'
inceptionYear = '2021'
+ licenses {
+ license {
+ name = 'The Apache Software License, Version 2.0'
+ url = 'https://www.apache.org/licenses/LICENSE-2.0.txt'
+ }
+ }
+ scm {
+ connection = 'scm:https://gitbox.apache.org/repos/asf/cassandra-accord.git'
+ developerConnection = 'scm:https://gitbox.apache.org/repos/asf/cassandra-accord.git'
+ url = 'https://gitbox.apache.org/repos/asf?p=cassandra-accord.git;a=tree'
+ }
+ }
+ // This is a hack to remove accord from the dependency list as this breaks Apache Cassandra
+ // This is a bug with Gradle that is fixed in 8.0 but not yet released
+ // see https://github.com/gradle/gradle/commit/6e596c638dff59dfa06032a7e7a3974275ddb3e1
+ pom.withXml {
+ asNode().dependencies.'*'.findAll() { it.artifactId.text() == accord_artifactId }.each() { it.parent().remove(it) }
}
from components.java
- }
-
- test(MavenPublication) {
Review Comment:
this caused a conflict with `artifactId`, the actual jar wouldn't conflict but the `pom` would, so this always overrode the pom of the previous task. I didn't notice this till now due to all the dependencies/version already being present in C* build... cleaned this up so we just publish a new jar without overriding the `pom`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org