[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6605: fs/mount: "df -h" fixes regarding datatype sizes

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #6605:
URL: https://github.com/apache/incubator-nuttx/pull/6605#discussion_r919612925


##########
fs/mount/fs_procfs_mount.c:
##########
@@ -248,6 +248,10 @@ static int blocks_entry(FAR const char *mountpoint,
 
   if (!info->header)
     {
+#if defined(CONFIG_HAVE_LONG_LONG) && !defined(CONFIG_LIBC_LONG_LONG)

Review Comment:
   since the code increase of long long is very little, look like it's better to remove CONFIG_LIBC_LONG_LONG and use CONFIG_HAVE_LONG_LONG instead.



##########
fs/mount/fs_procfs_mount.c:
##########
@@ -101,6 +101,7 @@ struct mount_info_s
 
 /* Helpers */
 
+printflike(2, 3)

Review Comment:
   move to the end



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org