[jira] [Commented] (TINKERPOP3-885) Change Transaction.onReadWrite() to be a ThreadLocal setting

["stephen mallette (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP3-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14955150#comment-14955150 ] 

stephen mallette commented on TINKERPOP3-885:
---------------------------------------------

Is there much to do with Gremlin Server here?  seems like all you need to do is make the change to {{ThreadLocal}} in {{Transaction}} for {{onReadWrite()}} - no?

> Change Transaction.onReadWrite() to be a ThreadLocal setting
> ------------------------------------------------------------
>
>                 Key: TINKERPOP3-885
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP3-885
>             Project: TinkerPop 3
>          Issue Type: Improvement
>          Components: server, structure
>    Affects Versions: 3.0.1-incubating
>            Reporter: Dylan Millikin
>            Assignee: Dylan Millikin
>              Labels: breaking
>             Fix For: 3.1.0-incubating
>
>
> The issue is as follows:
> Because Transaction consumers are global for a graph. A {{SessionOpProcessor}} request will change the Transaction read write behavior to {{MANUAL}} across all concurrent/future requests. 
> This will make other requests fail (ones expecting {{AUTO}}).
> This has been discussed here : http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/201510.mbox/browser
> The solution would be to make Transaction consumers ThreadLocal to keep the state local to the requests.
> This is a breaking change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)