You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/06/09 15:27:31 UTC
[GitHub] [arrow] westonpace opened a new pull request, #36011: GH-35858: [Python] disallow none schema parquet writer
westonpace opened a new pull request, #36011:
URL: https://github.com/apache/arrow/pull/36011
### Rationale for this change
Previously, passing in None for the schema would cause a segmentation fault.
### What changes are included in this PR?
Now a TypeError is raised instead
### Are these changes tested?
Yes, a new unit test is created
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #36011: GH-35858: [Python] disallow none schema parquet writer
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #36011:
URL: https://github.com/apache/arrow/pull/36011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #36011: GH-35858: [Python] disallow none schema parquet writer
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on PR #36011:
URL: https://github.com/apache/arrow/pull/36011#issuecomment-1589227465
Whoops, missed that the linting build is an actual failure, will do a quick fix-up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #36011: GH-35858: [Python] disallow none schema parquet writer
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36011:
URL: https://github.com/apache/arrow/pull/36011#issuecomment-1584767723
:warning: GitHub issue #35858 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on pull request #36011: GH-35858: [Python] disallow none schema parquet writer
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on PR #36011:
URL: https://github.com/apache/arrow/pull/36011#issuecomment-1589881002
Sorry about that. Thanks for cleaning it up!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #36011: GH-35858: [Python] disallow none schema parquet writer
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #36011:
URL: https://github.com/apache/arrow/pull/36011#issuecomment-1589652880
Benchmark runs are scheduled for baseline = 059d8b669aeeda0ab8ac1ae9eab336a93daa3613 and contender = 1ddeaab30b905b97c1c17a41daa1b3cd923e91d9. 1ddeaab30b905b97c1c17a41daa1b3cd923e91d9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:25.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b4eb28cd735942e1a3029f44f938bbab...f2fa33e4970a4cc688a3b5c0cdf303f7/)
[Finished :arrow_down:0.5% :arrow_up:0.03%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f7e07e8df4724c4588320d58a44b4b61...fd691bd506dc4327b319cfc9aab3bfa3/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/d836c137e6ab4283b140b0106c03f92a...8170095167bb4a6ca223efbeaf36df75/)
[Finished :arrow_down:0.54% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/d923a450e4ec46bba381aaa8ade63597...e74c5495048749398b2917e53ec942af/)
Buildkite builds:
[Finished] [`1ddeaab3` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3031)
[Finished] [`1ddeaab3` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3067)
[Finished] [`1ddeaab3` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3033)
[Finished] [`1ddeaab3` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3057)
[Finished] [`059d8b66` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/3030)
[Finished] [`059d8b66` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/3066)
[Finished] [`059d8b66` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/3031)
[Finished] [`059d8b66` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/3056)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org