[GitHub] [maven-clean-plugin] michael-o commented on a change in pull request #6: [MCLEAN-95] Add a fast clean option

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #6:
URL: https://github.com/apache/maven-clean-plugin/pull/6#discussion_r777932273



##########
File path: src/main/java/org/apache/maven/plugins/clean/CleanMojo.java
##########
@@ -229,8 +248,16 @@ else if ( fast && multiModuleProjectDirectory != null )
                         + "this plugin, or the 'maven.clean.fastDir' user property to be set." );
             }
         }
+        if ( fast && !FAST_MODE_BACKGROUND.equals( fastMode )
+                  && !FAST_MODE_AT_END.equals( fastMode )
+                  && !FAST_MODE_DEFER.equals( fastMode ) )
+        {
+            getLog().warn( "Illegal value '" + fastMode + "' for fastMode. Allowed values are '"
+                    + FAST_MODE_BACKGROUND + "', '" + FAST_MODE_AT_END + "' and '" + FAST_MODE_DEFER + "'. "
+                    + "Reverting to use the default value '" + FAST_MODE_BACKGROUND + "'." );
+        }

Review comment:
       Shouldn't this rather fail with an exception?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org