[GitHub] [incubator-druid] surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes

[GitBox <gi...@apache.org>]

surekhasaharan commented on a change in pull request #7368: maxTotalRows should be checked in DataSourceCompactionConfig before setting targetCompactionSizeBytes
URL: https://github.com/apache/incubator-druid/pull/7368#discussion_r270132800
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/indexing/ClientCompactQueryTuningConfig.java
 ##########
 @@ -31,15 +31,15 @@
 {
   // These default values should be synchronized with those of IndexTuningConfig
   private static final int DEFAULT_MAX_ROWS_IN_MEMORY = 75_000;
 
 Review comment:
   This value got changed to 1_000_000, may should get this from [here](https://github.com/apache/incubator-druid/blob/master/server/src/main/java/org/apache/druid/segment/indexing/TuningConfig.java#L37). Unless you need it to be 75_000.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org