[GitHub] [helix] narendly opened a new pull request #426: Add BucketDataAccessor for large writes

[GitBox <gi...@apache.org>]

narendly opened a new pull request #426: Add BucketDataAccessor for large writes
URL: https://github.com/apache/helix/pull/426
 
 
   ### Issues
   
   - [x] My PR addresses the following Helix issues and references them in the PR title:
   
   Resolves #419 
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   For the new WAGED rebalancer, it's necessary to have a data accessor that will allow writes of data exceeding 1MB to write assignment metadata. ZooKeeper's ZNode size is capped at 1MB, so BucketDataAccessor interface and ZkBucketDataAccessor help us achieve this.
   Changelist:
   1. Add BucketDataAccessor and ZkBucketDataAccessor
   2. Add necessary serializers
   3. Add an integration test against ZK
   
   ### Tests
   
   - [x] The following tests are written for this issue:
   
   **TestZkBucketDataAccessor**
   
   - [ ] The following is the result of the "mvn test" command on the appropriate module:
   
   (Copy & paste the result of "mvn test")
   
   ### Commits
   
   - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation in the following wiki page:
   
   https://github.com/apache/helix/wiki/Storing-Assignment-Metadata-in-ZooKeeper
   
   ### Code Quality
   
   - [x] My diff has been formatted using helix-style.xml
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org