[GitHub] [incubator-doris] caiconghui commented on a change in pull request #3955: Support checking database used data quota when data load job begin a new txn

[GitBox <gi...@apache.org>]

caiconghui commented on a change in pull request #3955:
URL: https://github.com/apache/incubator-doris/pull/3955#discussion_r449755668



##########
File path: fe/src/main/java/org/apache/doris/common/Config.java
##########
@@ -873,6 +873,18 @@
      */
     @ConfField(mutable = true, masterOnly = true)
     public static boolean disable_load_job = false;
+
+    /*
+     * if this is set to true, all load job will check db data quota when call begin txn api
+     */
+    @ConfField(mutable = true, masterOnly = true)
+    public static boolean enable_check_data_quota_on_load = false;

Review comment:
       done

##########
File path: fe/src/main/java/org/apache/doris/transaction/DatabaseTransactionMgr.java
##########
@@ -246,6 +249,10 @@ private void getTxnStateInfo(TransactionState txnState, List<String> info) {
     public long beginTransaction(List<Long> tableIdList, String label, TUniqueId requestId,
                                  TransactionState.TxnCoordinator coordinator, TransactionState.LoadJobSourceType sourceType, long listenerId, long timeoutSecond)
             throws DuplicatedRequestException, LabelAlreadyUsedException, BeginTransactionException, AnalysisException {
+        if (Config.enable_check_data_quota_on_load) {
+           checkDatabaseDataQuota();

Review comment:
       fix




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org