[GitHub] maskit commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls

[GitBox <gi...@apache.org>]

maskit commented on a change in pull request #1147: Add support for new configration interface to AuthenticaionTls
URL: https://github.com/apache/incubator-pulsar/pull/1147#discussion_r165090213
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/api/AuthenticationFactory.java
 ##########
 @@ -81,8 +65,9 @@ public static final Authentication create(String authPluginClassName, String aut
      * @param authParams          map which represents parameters for the Authentication-Plugin
      * @return instance of the Authentication-Plugin
      * @throws UnsupportedAuthenticationException
+     * @deprecated Use create(String authPluginClassName, String authParamsString)
      */
-    @SuppressWarnings("deprecation")
+    @Deprecated
     public static final Authentication create(String authPluginClassName, Map<String, String> authParams)
 
 Review comment:
   Hmm, yeah, we should consider the use case. Let me think about that. Passing a ?Map? doesn?t sound correct to me. Maybe it should be ?Object?.
   
   For now, I?ll update this PR within a few
    days to leave the method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services