You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/02/28 18:38:35 UTC

[GitHub] [camel-k] christophd opened a new pull request #3050: chore: Tune operator logging

christophd opened a new pull request #3050:
URL: https://github.com/apache/camel-k/pull/3050


   - Add ready after seconds metric as a structured log value
   - Set log level to debug when printing trait details in reconcile loop
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   NONE
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez merged pull request #3050: chore: Tune operator logging

Posted by GitBox <gi...@apache.org>.
squakez merged pull request #3050:
URL: https://github.com/apache/camel-k/pull/3050


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] christophd commented on pull request #3050: chore: Tune operator logging

Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #3050:
URL: https://github.com/apache/camel-k/pull/3050#issuecomment-1054551695


   The `Apply trait ...` info logging bloats the operator logs. We have seen this in dev sandbox performance testing with many integrations being reconciled


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] astefanutti commented on a change in pull request #3050: chore: Tune operator logging

Posted by GitBox <gi...@apache.org>.
astefanutti commented on a change in pull request #3050:
URL: https://github.com/apache/camel-k/pull/3050#discussion_r816164386



##########
File path: pkg/trait/trait_catalog.go
##########
@@ -127,6 +125,12 @@ func (c *Catalog) apply(environment *Environment) error {
 		}
 	}
 
+	traitIds := make([]string, 0)
+	for _, trait := range environment.ExecutedTraits {
+		traitIds = append(traitIds, string(trait.ID()))
+	}
+	c.L.Debugf("Applied traits: %s", strings.Join(traitIds, ","))

Review comment:
       I meant to do this for so long that I forgot about it :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org