You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Jesse Glick <no...@github.com> on 2018/05/23 00:09:24 UTC

[jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

[JCLOUDS-1422](https://issues.apache.org/jira/browse/JCLOUDS-1422)

Amends #788.

FYI @carlossg: encountered during https://github.com/jenkinsci/artifact-manager-s3-plugin/pull/28
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1212

-- Commit Summary --

  * Include the delimiter field in ListContainerOptions.toString.
  * [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined.

-- File Changes --

    M blobstore/src/main/java/org/jclouds/blobstore/config/LocalBlobStore.java (5)
    M blobstore/src/main/java/org/jclouds/blobstore/options/ListContainerOptions.java (1)
    M blobstore/src/test/java/org/jclouds/blobstore/strategy/internal/ListContainerTest.java (24)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1212.patch
https://github.com/jclouds/jclouds/pull/1212.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212

Re: [jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

Posted by Jesse Glick <no...@github.com>.
also CC @kuisathaverat

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212#issuecomment-394386662

Re: [jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

Posted by Andrew Gaul <no...@github.com>.
Rebased and pushed to master as 36353d6157a1c6c3f8f5e8497a68802a79784b12 and 11fac4f020b02a45ef9809e19656325ddf9efb25 and 2.1.x as 8d2808e3091a888e9812149e68fecd294628c0d3 and 3cb8d4f87ccb69b0ab4705ab6da6a1976b0c537d.  Thank you for your contribution @jglick!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212#issuecomment-395303105

Re: [jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

Posted by Jesse Glick <no...@github.com>.
jglick commented on this pull request.



> @@ -72,7 +72,7 @@ public void testListWithPrefix() {
       blobStore.putBlob(containerName, blobStore.blobBuilder("bar").payload("").build());
 
       Iterable<? extends StorageMetadata> results = concatter.execute(containerName,
-            ListContainerOptions.Builder.prefix(prefix).recursive());
+            ListContainerOptions.Builder.prefix(prefix)./* irrelevant */recursive());

No, noting that this test passes regardless of which way you set the `recursive` flag, which makes the name of the test a bit surprising.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212#discussion_r191465502

Re: [jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

Posted by Ivan Fernandez Calvo <no...@github.com>.
kuisathaverat approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212#pullrequestreview-125866116

Re: [jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

Posted by Andrew Gaul <no...@github.com>.
gaul commented on this pull request.



> @@ -72,7 +72,7 @@ public void testListWithPrefix() {
       blobStore.putBlob(containerName, blobStore.blobBuilder("bar").payload("").build());
 
       Iterable<? extends StorageMetadata> results = concatter.execute(containerName,
-            ListContainerOptions.Builder.prefix(prefix).recursive());
+            ListContainerOptions.Builder.prefix(prefix)./* irrelevant */recursive());

Stray comment?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212#pullrequestreview-122402359

Re: [jclouds/jclouds] [JCLOUDS-1422] Ensure that LocalBlobStore.list honors !recursive even when a prefix is defined (#1212)

Posted by Andrew Gaul <no...@github.com>.
Closed #1212.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1212#event-1667702566