You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/07/04 16:41:18 UTC

Review Request 23276: remove from hive-site.xml - hive.semantic.analyzer.factory.impl

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23276/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-6390
    https://issues.apache.org/jira/browse/AMBARI-6390


Repository: ambari


Description
-------

Ambari sets the following in hive-site.xml by default. But this parameter is
not used anymore.  
Having this param can be misleading.

hive.semantic.analyzer.factory.impl=org.apache.hivealog.cli.HCatSemanticAnalyz
erFactory

cc sush


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml f195bbc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HIVE/configuration/hive-site.xml b3ed5f5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml cf21dde 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/HIVE/configuration/hive-site.xml 5a8fb5a 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 5a8fb5a 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json 27b487f 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.json 3f79343 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json 17fae68 
  ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 8e0427b 
  ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json 0a36a75 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json cec663c 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 6c0121b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json 7295979 
  ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json d311afd 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f9db528 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 9cc17e4 
  ambari-server/src/test/python/stacks/2.1/configs/default.json 26e9738 
  ambari-server/src/test/python/stacks/2.1/configs/secured.json 2085e28 
  ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/configuration/hive-site.xml a69e250 
  ambari-server/src/test/resources/deploy_HDP2.sh 029e6f0 
  ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HIVE/configuration/hive-site.xml 7d35558 
  ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/hive-site.xml 40fa0a7 
  ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HIVE/configuration/hive-site.xml 7d35558 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 96b0d17 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/configuration/hive-site.xml f8ad94a 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/configuration/hive-site.xml a69e250 
  ambari-web/app/assets/data/configurations/cluster_level_configs.json c02317a 
  ambari-web/app/assets/data/wizard/stack/hdp/version01/HIVE.json 855a9f8 
  ambari-web/app/assets/data/wizard/stack/hdp/version1.2.1/HIVE.json 73baee4 
  ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HIVE.json 71fa5ed 
  ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/global.json 259fdfb 
  ambari-web/app/assets/data/wizard/stack/hdp/version131/HIVE.json bdc77b1 
  ambari-web/app/assets/data/wizard/stack/hdp/version131/global.json bc78d63 
  ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HIVE.json c943ac9 
  ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/global.json 259fdfb 

Diff: https://reviews.apache.org/r/23276/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 23276: remove from hive-site.xml - hive.semantic.analyzer.factory.impl

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23276/#review47344
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On July 4, 2014, 5:53 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23276/
> -----------------------------------------------------------
> 
> (Updated July 4, 2014, 5:53 p.m.)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-6390
>     https://issues.apache.org/jira/browse/AMBARI-6390
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari sets the following in hive-site.xml by default. But this parameter is
> not used anymore.  
> Having this param can be misleading.
> 
> hive.semantic.analyzer.factory.impl=org.apache.hivealog.cli.HCatSemanticAnalyz
> erFactory
> 
> cc sush
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml f195bbc 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HIVE/configuration/hive-site.xml b3ed5f5 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml cf21dde 
>   ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/HIVE/configuration/hive-site.xml 5a8fb5a 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 5a8fb5a 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json 27b487f 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.json 3f79343 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json 17fae68 
>   ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 8e0427b 
>   ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json 0a36a75 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json cec663c 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 6c0121b 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json 7295979 
>   ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json d311afd 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f9db528 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 9cc17e4 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json 26e9738 
>   ambari-server/src/test/python/stacks/2.1/configs/secured.json 2085e28 
>   ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/configuration/hive-site.xml a69e250 
>   ambari-server/src/test/resources/deploy_HDP2.sh 029e6f0 
>   ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HIVE/configuration/hive-site.xml 7d35558 
>   ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/hive-site.xml 40fa0a7 
>   ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HIVE/configuration/hive-site.xml 7d35558 
>   ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 96b0d17 
>   ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/configuration/hive-site.xml f8ad94a 
>   ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/configuration/hive-site.xml a69e250 
>   ambari-web/app/assets/data/configurations/cluster_level_configs.json c02317a 
>   ambari-web/app/assets/data/wizard/stack/hdp/version01/HIVE.json 855a9f8 
>   ambari-web/app/assets/data/wizard/stack/hdp/version1.2.1/HIVE.json 73baee4 
>   ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HIVE.json 71fa5ed 
>   ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/global.json 259fdfb 
>   ambari-web/app/assets/data/wizard/stack/hdp/version131/HIVE.json bdc77b1 
>   ambari-web/app/assets/data/wizard/stack/hdp/version131/global.json bc78d63 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HIVE.json c943ac9 
>   ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/global.json 259fdfb 
> 
> Diff: https://reviews.apache.org/r/23276/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 23276: remove from hive-site.xml - hive.semantic.analyzer.factory.impl

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23276/
-----------------------------------------------------------

(Updated July 4, 2014, 2:53 p.m.)


Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-6390
    https://issues.apache.org/jira/browse/AMBARI-6390


Repository: ambari


Description
-------

Ambari sets the following in hive-site.xml by default. But this parameter is
not used anymore.  
Having this param can be misleading.

hive.semantic.analyzer.factory.impl=org.apache.hivealog.cli.HCatSemanticAnalyz
erFactory

cc sush


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml f195bbc 
  ambari-server/src/main/resources/stacks/HDP/2.0.6.GlusterFS/services/HIVE/configuration/hive-site.xml b3ed5f5 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml cf21dde 
  ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/HIVE/configuration/hive-site.xml 5a8fb5a 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml 5a8fb5a 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.hbasedecom.json 27b487f 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.json 3f79343 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.non_gmetad_host.json 17fae68 
  ambari-server/src/test/python/stacks/1.3.2/configs/secured.json 8e0427b 
  ambari-server/src/test/python/stacks/1.3.2/configs/secured_no_jce_name.json 0a36a75 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.hbasedecom.json cec663c 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 6c0121b 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.non_gmetad_host.json 7295979 
  ambari-server/src/test/python/stacks/2.0.6/configs/flume_target.json d311afd 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured.json f9db528 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 9cc17e4 
  ambari-server/src/test/python/stacks/2.1/configs/default.json 26e9738 
  ambari-server/src/test/python/stacks/2.1/configs/secured.json 2085e28 
  ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/configuration/hive-site.xml a69e250 
  ambari-server/src/test/resources/deploy_HDP2.sh 029e6f0 
  ambari-server/src/test/resources/stacks/HDP/1.2.0/services/HIVE/configuration/hive-site.xml 7d35558 
  ambari-server/src/test/resources/stacks/HDP/1.3.0/services/HIVE/configuration/hive-site.xml 40fa0a7 
  ambari-server/src/test/resources/stacks/HDP/1.3.1/services/HIVE/configuration/hive-site.xml 7d35558 
  ambari-server/src/test/resources/stacks/HDP/2.0.1/services/HIVE/configuration/hive-site.xml 96b0d17 
  ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HIVE/configuration/hive-site.xml f8ad94a 
  ambari-server/src/test/resources/stacks/HDP/2.0.7/services/HIVE/configuration/hive-site.xml a69e250 
  ambari-web/app/assets/data/configurations/cluster_level_configs.json c02317a 
  ambari-web/app/assets/data/wizard/stack/hdp/version01/HIVE.json 855a9f8 
  ambari-web/app/assets/data/wizard/stack/hdp/version1.2.1/HIVE.json 73baee4 
  ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/HIVE.json 71fa5ed 
  ambari-web/app/assets/data/wizard/stack/hdp/version1.3.0/global.json 259fdfb 
  ambari-web/app/assets/data/wizard/stack/hdp/version131/HIVE.json bdc77b1 
  ambari-web/app/assets/data/wizard/stack/hdp/version131/global.json bc78d63 
  ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/HIVE.json c943ac9 
  ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/global.json 259fdfb 

Diff: https://reviews.apache.org/r/23276/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk