You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/22 16:19:38 UTC
[GitHub] [flink] Myasuka commented on a change in pull request #9255:
[FLINK-13034] Introduce isEmpty method for MapState
Myasuka commented on a change in pull request #9255: [FLINK-13034] Introduce isEmpty method for MapState
URL: https://github.com/apache/flink/pull/9255#discussion_r326908826
##########
File path: flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/utils/TestSharedBuffer.java
##########
@@ -219,6 +219,15 @@ public boolean contains(UK key) throws Exception {
return new CountingIterator<>(values.entrySet().iterator());
}
+ @Override
+ public boolean isEmpty() throws Exception {
+ if (values == null) {
+ return false;
Review comment:
good catch, this place should be `true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services