You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/04/21 21:55:33 UTC
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19782
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
IMPALA-12080: Create test partitions locally
Creates test partitions locally for test_recover_many_partitions to
avoid invoking the Java hdfs CLI repeatedly for non-HDFS filesystems.
This drastically reduces runtime for S3 and Ozone test runs.
Testing:
- tested with Ozone
Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
---
M tests/metadata/test_recover_partitions.py
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/19782/1
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9245/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:10:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@181
PS1, Line 181: SRC_DIR = os.path.join("/tmp", unique_database, TBL_NAME)
: if not os.path.exists(SRC_DIR):
: os.makedirs(SRC_DIR)
> Nit: Different approach would be to delete the directory if it already exis
Yeah, that probably makes sense here.
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 22:51:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12833/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 22:16:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
IMPALA-12080: Create test partitions locally
Creates test partitions locally for test_recover_many_partitions to
avoid invoking the Java hdfs CLI repeatedly for non-HDFS filesystems.
This drastically reduces runtime for S3 and Ozone test runs.
Testing:
- tested with Ozone and S3
Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Reviewed-on: http://gerrit.cloudera.org:8080/19782
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/metadata/test_recover_partitions.py
1 file changed, 15 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@181
PS1, Line 181: # Create 700 partitions externally
: try:
: SRC_DIR = os.path.join
> Yeah, that probably makes sense here.
Done
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@190
PS1, Line 190: with open(os.path.join(partition_dir, "test"), 'w') as f
> Let's cleanup the temp directory after this.
Done
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:03:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 1:
(2 comments)
This makes sense to me, just some minor nits
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@181
PS1, Line 181: SRC_DIR = os.path.join("/tmp", unique_database, TBL_NAME)
: if not os.path.exists(SRC_DIR):
: os.makedirs(SRC_DIR)
Nit: Different approach would be to delete the directory if it already exists, then start from scratch.
http://gerrit.cloudera.org:8080/#/c/19782/1/tests/metadata/test_recover_partitions.py@190
PS1, Line 190: self.filesystem_client.copy_from_local(SRC_DIR, DB_LOCATION)
Let's cleanup the temp directory after this.
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 22:47:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12834/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:24:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19782
to look at the new patch set (#2).
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
IMPALA-12080: Create test partitions locally
Creates test partitions locally for test_recover_many_partitions to
avoid invoking the Java hdfs CLI repeatedly for non-HDFS filesystems.
This drastically reduces runtime for S3 and Ozone test runs.
Testing:
- tested with Ozone and S3
Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
---
M tests/metadata/test_recover_partitions.py
1 file changed, 15 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/82/19782/2
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 2: Code-Review+2
Looks good, thanks for fixing it
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:09:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 Apr 2023 04:24:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12080: Create test partitions locally
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19782 )
Change subject: IMPALA-12080: Create test partitions locally
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab8c2f49c1940a3a63a279a911e0897b5ed8808e
Gerrit-Change-Number: 19782
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Apr 2023 23:10:39 +0000
Gerrit-HasComments: No