You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2017/12/20 22:49:11 UTC

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/* 

David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8896


Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................

Move symlinked auxiliary tests/* to tests/functional/*

The layout of the Impala-auxiliary-tests/tests directory is
changing to allow for different kinds of tests to be saved
there.

Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
---
M bin/create-test-configuration.sh
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/8896/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+1
> 
> (1 comment)

Thanks. Great suggestion.


-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Dec 2017 23:12:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................

Move symlinked auxiliary tests/* to tests/functional/*

The layout of the Impala-auxiliary-tests/tests directory is
changing to allow for different kinds of tests to be saved
there. But just in case the new functional sub-directory
does not exist, preserve backwards compatibility with the
older layout.

Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Reviewed-on: http://gerrit.cloudera.org:8080/8896
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/create-test-configuration.sh
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  David Knupp: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Matthew Mulder, Michael Brown, Philip Zeyliger, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8896

to look at the new patch set (#3).

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................

Move symlinked auxiliary tests/* to tests/functional/*

The layout of the Impala-auxiliary-tests/tests directory is
changing to allow for different kinds of tests to be saved
there. But just in case the new functional sub-directory
does not exist, preserve backwards compatibility with the
older layout.

Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
---
M bin/create-test-configuration.sh
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/8896/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 00:00:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8896/2/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:

http://gerrit.cloudera.org:8080/#/c/8896/2/bin/create-test-configuration.sh@195
PS2, Line 195:  
> This looks like a stray }
Good catch. Thanks.



-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Dec 2017 00:57:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Matthew Mulder, Michael Brown, Philip Zeyliger, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8896

to look at the new patch set (#2).

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................

Move symlinked auxiliary tests/* to tests/functional/*

The layout of the Impala-auxiliary-tests/tests directory is
changing to allow for different kinds of tests to be saved
there. But just in case the new functional sub-directory
does not exist, preserve backwards compatibility with the
older layout.

Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
---
M bin/create-test-configuration.sh
1 file changed, 8 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/8896/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Matthew Mulder (Code Review)" <ge...@cloudera.org>.
Matthew Mulder has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8896/2/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:

http://gerrit.cloudera.org:8080/#/c/8896/2/bin/create-test-configuration.sh@195
PS2, Line 195: }
This looks like a stray }



-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Dec 2017 00:22:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 04:48:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Matthew Mulder (Code Review)" <ge...@cloudera.org>.
Matthew Mulder has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

I ran just that bit of script that creates the test links and it works with or without the functional dir.

http://gerrit.cloudera.org:8080/#/c/8896/2/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:

http://gerrit.cloudera.org:8080/#/c/8896/2/bin/create-test-configuration.sh@195
PS2, Line 195:  
> Good catch. Thanks.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Dec 2017 02:30:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Dec 2017 00:07:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1647/


-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 01:16:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/8896/1/bin/create-test-configuration.sh
File bin/create-test-configuration.sh:

http://gerrit.cloudera.org:8080/#/c/8896/1/bin/create-test-configuration.sh@194
PS1, Line 194: symlink_subdirs ${IMPALA_AUX_TEST_HOME}/tests/functional ${IMPALA_HOME}/tests
Since any users of this would need to update their repositories, do you want to preserve the old behavior if tests/functional doesn't exist?

i.e.,

if [ -e ${IMPALA_AUX_TEST_HOME}/tests/functional} ]; then
  symlink_subdirs ${IMPALA_AUX_TEST_HOME}/tests/functional ${IMPALA_HOME}/tests
else
  # For compatibility with older auxiliary tests, which aren't in the functional subdirectory.
  symlink_subdirs ${IMPALA_AUX_TEST_HOME}/tests ${IMPALA_HOME}/tests
fi



-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Wed, 20 Dec 2017 23:04:53 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] Move symlinked auxiliary tests/* to tests/functional/*

Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/8896 )

Change subject: Move symlinked auxiliary tests/* to tests/functional/*
......................................................................


Patch Set 4: Code-Review+2

Carrying +2 after rebase.


-- 
To view, visit http://gerrit.cloudera.org:8080/8896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb2bbbebc38bbaf3d6a4ad01fa8dd918b7d99b3b
Gerrit-Change-Number: 8896
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Matthew Mulder <mm...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 01:15:55 +0000
Gerrit-HasComments: No