You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@toree.apache.org by lr...@apache.org on 2023/08/10 16:31:25 UTC
[incubator-toree] branch master updated: [TOREE-549] Fix flaky test by closing pubSocket quietly (#215)
This is an automated email from the ASF dual-hosted git repository.
lresende pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-toree.git
The following commit(s) were added to refs/heads/master by this push:
new 86f6561f [TOREE-549] Fix flaky test by closing pubSocket quietly (#215)
86f6561f is described below
commit 86f6561fc34e997beaf2a5fcd01dd553afdd5a4c
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Fri Aug 11 00:31:19 2023 +0800
[TOREE-549] Fix flaky test by closing pubSocket quietly (#215)
---
.../communication/socket/ZeroMQSocketRunnableSpec.scala | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/communication/src/test/scala/org/apache/toree/communication/socket/ZeroMQSocketRunnableSpec.scala b/communication/src/test/scala/org/apache/toree/communication/socket/ZeroMQSocketRunnableSpec.scala
index b77a6efd..384e3770 100644
--- a/communication/src/test/scala/org/apache/toree/communication/socket/ZeroMQSocketRunnableSpec.scala
+++ b/communication/src/test/scala/org/apache/toree/communication/socket/ZeroMQSocketRunnableSpec.scala
@@ -134,7 +134,7 @@ class ZeroMQSocketRunnableSpec extends FunSpec with Matchers
actual should be (expected)
}
- runnable.close()
+ Try(runnable.close())
}
it("should set the identity option when provided") {
@@ -157,7 +157,7 @@ class ZeroMQSocketRunnableSpec extends FunSpec with Matchers
actual should be (expected)
}
- runnable.close()
+ Try(runnable.close())
}
it("should close the thread when closed"){
@@ -177,7 +177,7 @@ class ZeroMQSocketRunnableSpec extends FunSpec with Matchers
runnable.isProcessing should be (true)
}
- runnable.close()
+ Try(runnable.close())
eventually{
thread.isAlive should be (false)
@@ -203,7 +203,7 @@ class ZeroMQSocketRunnableSpec extends FunSpec with Matchers
runnable.isProcessing should be (true)
}
- runnable.close()
+ Try(runnable.close())
eventually {
runnable.isProcessing should be (false)
@@ -227,7 +227,7 @@ class ZeroMQSocketRunnableSpec extends FunSpec with Matchers
runnable.isProcessing should be (true)
}
- runnable.close()
+ Try(runnable.close())
}
}
@@ -249,7 +249,7 @@ class ZeroMQSocketRunnableSpec extends FunSpec with Matchers
runnable.isProcessing should be (true)
}
- runnable.close()
+ Try(runnable.close())
eventually{
thread.isAlive should be(false)