[GitHub] [arrow] lidavidm commented on a diff in pull request #34342: GH-33466: [Go][Parquet] Add support for Dictionary arrays to pqarrow

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on code in PR #34342:
URL: https://github.com/apache/arrow/pull/34342#discussion_r1118710350


##########
go/arrow/array/dictionary.go:
##########
@@ -883,6 +885,60 @@ func (b *dictionaryBuilder) AppendArray(arr arrow.Array) error {
 	return nil
 }
 
+func (b *dictionaryBuilder) AppendIndices(indices []int, valid []bool) {

Review Comment:
   Do these new functions have direct unit tests? (I'm assuming they're tested indirectly by other functions, but I don't see explicit tests.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org