You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by vmx <gi...@git.apache.org> on 2013/03/10 21:22:51 UTC
couchdb pull request: Fix CORS error with attachments
GitHub user vmx opened a pull request:
https://github.com/apache/couchdb/pull/47
Fix CORS error with attachments
When attachments were returned (?attachments=true) while CORS was
enabled and used, an error occured. The reason for this error
were headers that were encoded as binaries instead of lists. String
operations on binaries throw errors.
This commit fixes COUCHDB-1689.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb/pull/47.patch
----
commit b0420f9006915149e81607615720f32f21c76725
Author: Volker Mische <vo...@gmail.com>
Date: 2013-03-10T17:34:59Z
Fix CORS error with attachments
When attachments were returned (?attachments=true) while CORS was
enabled and used, an error occured. The reason for this error
were headers that were encoded as binaries instead of lists. String
operations on binaries throw errors.
This commit fixes COUCHDB-1689.
----
Re: couchdb pull request: Fix CORS error with attachments
Posted by Volker Mische <vo...@gmail.com>.
Code review is useful. It can also be done directly on the pull request.
Not sure if we stick to Github, or use some other reviewing tool.
Cheers,
Volker
On 03/10/2013 09:37 PM, Noah Slater wrote:
> Not sure if this is related, but I suggested we try out Review Board a few
> months ago. I have seen it used on other projects when people just want a
> code review before commit. Would people find that useful?
>
>
> On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
>
>> GitHub user vmx opened a pull request:
>>
>> https://github.com/apache/couchdb/pull/47
>>
>> Fix CORS error with attachments
>>
>> When attachments were returned (?attachments=true) while CORS was
>> enabled and used, an error occured. The reason for this error
>> were headers that were encoded as binaries instead of lists. String
>> operations on binaries throw errors.
>>
>> This commit fixes COUCHDB-1689.
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/couchdb/pull/47.patch
>>
>> ----
>> commit b0420f9006915149e81607615720f32f21c76725
>> Author: Volker Mische <vo...@gmail.com>
>> Date: 2013-03-10T17:34:59Z
>>
>> Fix CORS error with attachments
>>
>> When attachments were returned (?attachments=true) while CORS was
>> enabled and used, an error occured. The reason for this error
>> were headers that were encoded as binaries instead of lists. String
>> operations on binaries throw errors.
>>
>> This commit fixes COUCHDB-1689.
>>
>> ----
>>
>>
>
>
Re: couchdb pull request: Fix CORS error with attachments
Posted by Jan Lehnardt <ja...@apache.org>.
On Mar 10, 2013, at 21:53 , Noah Slater <ns...@apache.org> wrote:
> Well, it might be a nice way for:
>
> * Non-committers to submit work (without us asking them to use Github)
> * New committers to get started before they feel confident to adopt the CTR
> model
> * Established committers to request a second set of eyeballs before the
> commit lands on master
I am all for making the current process easier, but I don’t quite see how
adding more steps helps here.
Current ways to submit work:
- Email or link a patch to dev@ or JIRA.
- Email or link a git commit on dev@ or JIRA.
- Open a pull request on Github.
What are we missing?
> “without us asking them to use Github”
The situations tends to be that we need to ask people not to use Github
than the other way around.
Cheers
Jan
--
>
>
> On 10 March 2013 20:49, Jan Lehnardt <ja...@apache.org> wrote:
>
>>
>> On Mar 10, 2013, at 21:37 , Noah Slater <ns...@apache.org> wrote:
>>
>>> Not sure if this is related, but I suggested we try out Review Board a
>> few
>>> months ago. I have seen it used on other projects when people just want a
>>> code review before commit. Would people find that useful?
>>
>> I post to asf git and github which serves as enough of a review system for
>> my work, but I wouldn’t be opposed if others wanted it.
>>
>>
>>>
>>>
>>> On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
>>>
>>>> GitHub user vmx opened a pull request:
>>>>
>>>> https://github.com/apache/couchdb/pull/47
>>>>
>>>> Fix CORS error with attachments
>>>>
>>>> When attachments were returned (?attachments=true) while CORS was
>>>> enabled and used, an error occured. The reason for this error
>>>> were headers that were encoded as binaries instead of lists. String
>>>> operations on binaries throw errors.
>>>>
>>>> This commit fixes COUCHDB-1689.
>>>>
>>>> You can merge this pull request into a Git repository by running:
>>>>
>>>> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>>>>
>>>> Alternatively you can review and apply these changes as the patch at:
>>>>
>>>> https://github.com/apache/couchdb/pull/47.patch
>>>>
>>>> ----
>>>> commit b0420f9006915149e81607615720f32f21c76725
>>>> Author: Volker Mische <vo...@gmail.com>
>>>> Date: 2013-03-10T17:34:59Z
>>>>
>>>> Fix CORS error with attachments
>>>>
>>>> When attachments were returned (?attachments=true) while CORS was
>>>> enabled and used, an error occured. The reason for this error
>>>> were headers that were encoded as binaries instead of lists. String
>>>> operations on binaries throw errors.
>>>>
>>>> This commit fixes COUCHDB-1689.
>>>>
>>>> ----
>>>>
>>>>
>>>
>>>
>>> --
>>> NS
>>
>>
>
>
> --
> NS
Re: couchdb pull request: Fix CORS error with attachments
Posted by Noah Slater <ns...@apache.org>.
Well, it might be a nice way for:
* Non-committers to submit work (without us asking them to use Github)
* New committers to get started before they feel confident to adopt the CTR
model
* Established committers to request a second set of eyeballs before the
commit lands on master
On 10 March 2013 20:49, Jan Lehnardt <ja...@apache.org> wrote:
>
> On Mar 10, 2013, at 21:37 , Noah Slater <ns...@apache.org> wrote:
>
> > Not sure if this is related, but I suggested we try out Review Board a
> few
> > months ago. I have seen it used on other projects when people just want a
> > code review before commit. Would people find that useful?
>
> I post to asf git and github which serves as enough of a review system for
> my work, but I wouldn’t be opposed if others wanted it.
>
>
> >
> >
> > On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
> >
> >> GitHub user vmx opened a pull request:
> >>
> >> https://github.com/apache/couchdb/pull/47
> >>
> >> Fix CORS error with attachments
> >>
> >> When attachments were returned (?attachments=true) while CORS was
> >> enabled and used, an error occured. The reason for this error
> >> were headers that were encoded as binaries instead of lists. String
> >> operations on binaries throw errors.
> >>
> >> This commit fixes COUCHDB-1689.
> >>
> >> You can merge this pull request into a Git repository by running:
> >>
> >> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
> >>
> >> Alternatively you can review and apply these changes as the patch at:
> >>
> >> https://github.com/apache/couchdb/pull/47.patch
> >>
> >> ----
> >> commit b0420f9006915149e81607615720f32f21c76725
> >> Author: Volker Mische <vo...@gmail.com>
> >> Date: 2013-03-10T17:34:59Z
> >>
> >> Fix CORS error with attachments
> >>
> >> When attachments were returned (?attachments=true) while CORS was
> >> enabled and used, an error occured. The reason for this error
> >> were headers that were encoded as binaries instead of lists. String
> >> operations on binaries throw errors.
> >>
> >> This commit fixes COUCHDB-1689.
> >>
> >> ----
> >>
> >>
> >
> >
> > --
> > NS
>
>
--
NS
Re: couchdb pull request: Fix CORS error with attachments
Posted by Jan Lehnardt <ja...@apache.org>.
On Mar 10, 2013, at 21:37 , Noah Slater <ns...@apache.org> wrote:
> Not sure if this is related, but I suggested we try out Review Board a few
> months ago. I have seen it used on other projects when people just want a
> code review before commit. Would people find that useful?
I post to asf git and github which serves as enough of a review system for my work, but I wouldn’t be opposed if others wanted it.
>
>
> On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
>
>> GitHub user vmx opened a pull request:
>>
>> https://github.com/apache/couchdb/pull/47
>>
>> Fix CORS error with attachments
>>
>> When attachments were returned (?attachments=true) while CORS was
>> enabled and used, an error occured. The reason for this error
>> were headers that were encoded as binaries instead of lists. String
>> operations on binaries throw errors.
>>
>> This commit fixes COUCHDB-1689.
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/couchdb/pull/47.patch
>>
>> ----
>> commit b0420f9006915149e81607615720f32f21c76725
>> Author: Volker Mische <vo...@gmail.com>
>> Date: 2013-03-10T17:34:59Z
>>
>> Fix CORS error with attachments
>>
>> When attachments were returned (?attachments=true) while CORS was
>> enabled and used, an error occured. The reason for this error
>> were headers that were encoded as binaries instead of lists. String
>> operations on binaries throw errors.
>>
>> This commit fixes COUCHDB-1689.
>>
>> ----
>>
>>
>
>
> --
> NS
Re: couchdb pull request: Fix CORS error with attachments
Posted by Noah Slater <ns...@apache.org>.
Not sure if this is related, but I suggested we try out Review Board a few
months ago. I have seen it used on other projects when people just want a
code review before commit. Would people find that useful?
On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
> GitHub user vmx opened a pull request:
>
> https://github.com/apache/couchdb/pull/47
>
> Fix CORS error with attachments
>
> When attachments were returned (?attachments=true) while CORS was
> enabled and used, an error occured. The reason for this error
> were headers that were encoded as binaries instead of lists. String
> operations on binaries throw errors.
>
> This commit fixes COUCHDB-1689.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/couchdb/pull/47.patch
>
> ----
> commit b0420f9006915149e81607615720f32f21c76725
> Author: Volker Mische <vo...@gmail.com>
> Date: 2013-03-10T17:34:59Z
>
> Fix CORS error with attachments
>
> When attachments were returned (?attachments=true) while CORS was
> enabled and used, an error occured. The reason for this error
> were headers that were encoded as binaries instead of lists. String
> operations on binaries throw errors.
>
> This commit fixes COUCHDB-1689.
>
> ----
>
>
--
NS
Re: couchdb pull request: Fix CORS error with attachments
Posted by Noah Slater <ns...@apache.org>.
*Blinks*
My mistake... :3
On 10 March 2013 20:48, Jan Lehnardt <ja...@apache.org> wrote:
>
> On Mar 10, 2013, at 21:36 , Noah Slater <ns...@apache.org> wrote:
>
> > Volker,
> >
> > Are you able to commit directly to the Apache repository?
>
> he is not a committer.
>
> >
> >
> > On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
> >
> >> GitHub user vmx opened a pull request:
> >>
> >> https://github.com/apache/couchdb/pull/47
> >>
> >> Fix CORS error with attachments
> >>
> >> When attachments were returned (?attachments=true) while CORS was
> >> enabled and used, an error occured. The reason for this error
> >> were headers that were encoded as binaries instead of lists. String
> >> operations on binaries throw errors.
> >>
> >> This commit fixes COUCHDB-1689.
> >>
> >> You can merge this pull request into a Git repository by running:
> >>
> >> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
> >>
> >> Alternatively you can review and apply these changes as the patch at:
> >>
> >> https://github.com/apache/couchdb/pull/47.patch
> >>
> >> ----
> >> commit b0420f9006915149e81607615720f32f21c76725
> >> Author: Volker Mische <vo...@gmail.com>
> >> Date: 2013-03-10T17:34:59Z
> >>
> >> Fix CORS error with attachments
> >>
> >> When attachments were returned (?attachments=true) while CORS was
> >> enabled and used, an error occured. The reason for this error
> >> were headers that were encoded as binaries instead of lists. String
> >> operations on binaries throw errors.
> >>
> >> This commit fixes COUCHDB-1689.
> >>
> >> ----
> >>
> >>
> >
> >
> > --
> > NS
>
>
--
NS
Re: couchdb pull request: Fix CORS error with attachments
Posted by Jan Lehnardt <ja...@apache.org>.
On Mar 10, 2013, at 21:36 , Noah Slater <ns...@apache.org> wrote:
> Volker,
>
> Are you able to commit directly to the Apache repository?
he is not a committer.
>
>
> On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
>
>> GitHub user vmx opened a pull request:
>>
>> https://github.com/apache/couchdb/pull/47
>>
>> Fix CORS error with attachments
>>
>> When attachments were returned (?attachments=true) while CORS was
>> enabled and used, an error occured. The reason for this error
>> were headers that were encoded as binaries instead of lists. String
>> operations on binaries throw errors.
>>
>> This commit fixes COUCHDB-1689.
>>
>> You can merge this pull request into a Git repository by running:
>>
>> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>>
>> Alternatively you can review and apply these changes as the patch at:
>>
>> https://github.com/apache/couchdb/pull/47.patch
>>
>> ----
>> commit b0420f9006915149e81607615720f32f21c76725
>> Author: Volker Mische <vo...@gmail.com>
>> Date: 2013-03-10T17:34:59Z
>>
>> Fix CORS error with attachments
>>
>> When attachments were returned (?attachments=true) while CORS was
>> enabled and used, an error occured. The reason for this error
>> were headers that were encoded as binaries instead of lists. String
>> operations on binaries throw errors.
>>
>> This commit fixes COUCHDB-1689.
>>
>> ----
>>
>>
>
>
> --
> NS
Re: couchdb pull request: Fix CORS error with attachments
Posted by Noah Slater <ns...@apache.org>.
Volker,
Are you able to commit directly to the Apache repository?
On 10 March 2013 20:22, vmx <gi...@git.apache.org> wrote:
> GitHub user vmx opened a pull request:
>
> https://github.com/apache/couchdb/pull/47
>
> Fix CORS error with attachments
>
> When attachments were returned (?attachments=true) while CORS was
> enabled and used, an error occured. The reason for this error
> were headers that were encoded as binaries instead of lists. String
> operations on binaries throw errors.
>
> This commit fixes COUCHDB-1689.
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/vmx/couchdb 1689-fix-cors-attachments
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/couchdb/pull/47.patch
>
> ----
> commit b0420f9006915149e81607615720f32f21c76725
> Author: Volker Mische <vo...@gmail.com>
> Date: 2013-03-10T17:34:59Z
>
> Fix CORS error with attachments
>
> When attachments were returned (?attachments=true) while CORS was
> enabled and used, an error occured. The reason for this error
> were headers that were encoded as binaries instead of lists. String
> operations on binaries throw errors.
>
> This commit fixes COUCHDB-1689.
>
> ----
>
>
--
NS