You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/08/10 15:49:09 UTC
[GitHub] flink pull request #4518: [FLINK-7412][network] optimise NettyMessage.TaskEv...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4518
[FLINK-7412][network] optimise NettyMessage.TaskEventRequest#readFrom() to read from netty buffers directly
## What is the purpose of the change
`NettyMessage.TaskEventRequest#readFrom()` had an outstanding TODO to read from the netty buffer directly, instead of copying to a `ByteBuffer` first and then deserializing the event.
## Brief change log
- use `ByteBuf#nioBuffer()` to deserialize from a `ByteBuffer` instance wrapping netty's buffer contents
## Verifying this change
This change is already covered by existing tests, such as `NettyMessageSerializationTest` as well as many other tests, especially IT cases, involving network.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (yes)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes, if you consider network communication part of this)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7412
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4518
----
commit b33e036b43d00ddf564f105280894f6287dd3e92
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-08-07T15:38:36Z
[FLINK-7411][network] minor (performance) improvements in NettyMessage
* use a switch rather than multiple if conditions
* use static `readFrom` methods to create instances of the message sub types
commit bce73af1b01793574d748e6536052ec6530360b0
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-08-07T16:12:28Z
[FLINK-7412][network] optimise NettyMessage.TaskEventRequest#readFrom() to read from netty buffers directly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4518: [FLINK-7412][network] optimise NettyMessage.TaskEv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4518
---
[GitHub] flink issue #4518: [FLINK-7412][network] optimise NettyMessage.TaskEventRequ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4518
Thanks for the reminder @zentol :-) Will merge it now since the failing test case is unrelated.
---
[GitHub] flink pull request #4518: [FLINK-7412][network] optimise NettyMessage.TaskEv...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4518#discussion_r141373324
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java ---
@@ -440,12 +440,11 @@ ByteBuf write(ByteBufAllocator allocator) throws IOException {
static TaskEventRequest readFrom(ByteBuf buffer, ClassLoader classLoader) throws IOException {
TaskEventRequest result = new TaskEventRequest();
- // TODO Directly deserialize fromNetty's buffer
+ // directly deserialize fromNetty's buffer
int length = buffer.readInt();
- ByteBuffer serializedEvent = ByteBuffer.allocate(length);
-
- buffer.readBytes(serializedEvent);
- serializedEvent.flip();
+ ByteBuffer serializedEvent = buffer.nioBuffer();
--- End diff --
yes, makes sense to change this as an additional safeguard
---
[GitHub] flink issue #4518: [FLINK-7412][network] optimise NettyMessage.TaskEventRequ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4518
Thanks for the contribution @NicoK and the review @pnowojski. Once Travis passed, I'll merge the PR.
---
[GitHub] flink pull request #4518: [FLINK-7412][network] optimise NettyMessage.TaskEv...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4518#discussion_r136834211
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java ---
@@ -440,12 +440,11 @@ ByteBuf write(ByteBufAllocator allocator) throws IOException {
static TaskEventRequest readFrom(ByteBuf buffer, ClassLoader classLoader) throws IOException {
TaskEventRequest result = new TaskEventRequest();
- // TODO Directly deserialize fromNetty's buffer
+ // directly deserialize fromNetty's buffer
int length = buffer.readInt();
- ByteBuffer serializedEvent = ByteBuffer.allocate(length);
-
- buffer.readBytes(serializedEvent);
- serializedEvent.flip();
+ ByteBuffer serializedEvent = buffer.nioBuffer();
--- End diff --
`buffer.nioBuffer(buffer.readerIndex(), length);` ?
---
[GitHub] flink issue #4518: [FLINK-7412][network] optimise NettyMessage.TaskEventRequ...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4518
@tillrohrmann Friendly reminder that you wanted to merge this PR.
---