You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by Attsun1031 <gi...@git.apache.org> on 2015/09/21 06:22:07 UTC
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
GitHub user Attsun1031 opened a pull request:
https://github.com/apache/spark/pull/8845
[SPARK-10723] Add reduceOption API to RDD
This is PR for https://issues.apache.org/jira/browse/SPARK-10723
#### Question
When I ran tests, mima binary compatibility test failed because of following error.
```
method reduceOption(org.apache.spark.api.java.function.Function2)com.google.common.base.Optional in trait org.apache.spark.api.java.JavaRDDL
ike does not have a correspondent in old version
```
To avoid this error, I mark reduceOption method as Experimental, and pass mima tests.
Is it proper way to cope with such error ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Attsun1031/spark reduce-option
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8845.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8845
----
commit 4d75261084c67431199e9cac45125b1c0dcba386
Author: Attsun <at...@gmail.com>
Date: 2015-09-06T13:10:16Z
Add reduceOption API to RDD
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8845#issuecomment-142058584
Do you mind closing this PR? There are a couple votes for wont-fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8845#issuecomment-141904727
Yes, you can't quite just add the method to this trait as it is technically a breaking change. For various reasons, i believe we can exclude it.
However, I personally am not convinced this method pulls its weight and justifies the change. You can use `isEmpty` and I'm not sure the JIRA notes that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
Posted by davies <gi...@git.apache.org>.
Github user davies commented on the pull request:
https://github.com/apache/spark/pull/8845#issuecomment-144180734
@Attsun1031 Can you close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8845#issuecomment-141873682
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
Posted by Attsun1031 <gi...@git.apache.org>.
Github user Attsun1031 commented on the pull request:
https://github.com/apache/spark/pull/8845#issuecomment-142152296
Thanks for comment and advice. I'll use isEmpty or fold to deal with my case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-10723] Add reduceOption API to RDD
Posted by Attsun1031 <gi...@git.apache.org>.
Github user Attsun1031 closed the pull request at:
https://github.com/apache/spark/pull/8845
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org