[jira] [Commented] (CLIMATE-947) Updates in cordex.py

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLIMATE-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333770#comment-16333770 ] 

ASF GitHub Bot commented on CLIMATE-947:
----------------------------------------

GitHub user huikyole opened a pull request:

    https://github.com/apache/climate/pull/496

    CLIMATE-947 - Updates in cordex.py

    The goal of this PR is to facilitate building a RCMES docker image.
    
      - The variable 'errored' is defined outside a for loop.
       - domain, workdir, obs_dir, and models_dir can be sys.argv


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/huikyole/climate CLIMATE-947

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/climate/pull/496.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #496
    
----
commit c2ca575d194fe90f1550a065c7646836780441e7
Author: huikyole <hu...@...>
Date:   2018-01-22T01:30:12Z

    CLIMATE-947 - Updates in cordex.py

----


> Updates in cordex.py
> --------------------
>
>                 Key: CLIMATE-947
>                 URL: https://issues.apache.org/jira/browse/CLIMATE-947
>             Project: Apache Open Climate Workbench
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Huikyo Lee
>            Assignee: Huikyo Lee
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> A RCMES user made several suggestions to improve cordex.py. The goal is to facilitate building a RCMES docker image.
>  * the variable 'errored' needs to be defined outside a for loop.
>  * It would be better to make domain, workdir, obs_dir, and models_dir become input parameters.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)