You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "herunkang2018 (via GitHub)" <gi...@apache.org> on 2024/10/20 10:05:05 UTC

Re: [PR] [FLINK-36309][pipeline-connector/paimon] Paimon Sink commit failed should log stackTrace [flink-cdc]

herunkang2018 commented on code in PR #3611:
URL: https://github.com/apache/flink-cdc/pull/3611#discussion_r1807751522


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/PaimonCommitter.java:
##########
@@ -72,15 +72,16 @@ public void commit(Collection<CommitRequest<MultiTableCommittable>> commitReques
             }
             commitRequests.forEach(CommitRequest::signalAlreadyCommitted);
             LOGGER.info(
-                    String.format(
-                            "Commit succeeded for %s with %s committable",
-                            checkpointId, committables.size()));
+                    "Commit succeeded for {} with {} committable",

Review Comment:
   Could we add retry number information in this log to help user to troubleshoot problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org