You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by davinash <gi...@git.apache.org> on 2017/05/24 02:45:00 UTC

[GitHub] geode pull request #529: GEODE-2980: All the methods in an interface are imp...

GitHub user davinash opened a pull request:

    https://github.com/apache/geode/pull/529

    GEODE-2980: All the methods in an interface are implicitly public and abstract.

    All fields in the interface are implicitly public, static and final.
    Removing this from all the interface.
    Pre-checkin pass.
    
    Thank you for submitting a contribution to Apache Geode.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    - [X] Does `gradlew build` run cleanly?
    
    - [ ] Have you written or updated unit tests to verify your changes?
    Not required for this change
    
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    NA
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and
    submit an update to your PR as soon as possible. If you need help, please send an
    email to dev@geode.apache.org.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davinash/geode feature/GEODE-2980

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/529.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #529
    
----
commit 8e6fdeec35ab62b3913dab9292fefe604fa340ad
Author: Avinash <av...@ampool.io>
Date:   2017-05-23T03:55:02Z

    All the methods in an interface are implicitly public and abstract.
    All fields in the interface are implicitly public, static and final.
    Removing this from all the interface.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #529: GEODE-2980: All the methods in an interface are implicitly...

Posted by kirklund <gi...@git.apache.org>.
Github user kirklund commented on the issue:

    https://github.com/apache/geode/pull/529
  
    @davinash please rebase on develop to fix the new conflicts and I'll merge to develop. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #529: GEODE-2980: All the methods in an interface are implicitly...

Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:

    https://github.com/apache/geode/pull/529
  
    Hi @kirklund Updated the PR and running the tests now again. Please review and you can merge the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #529: GEODE-2980: All the methods in an interface are implicitly...

Posted by davinash <gi...@git.apache.org>.
Github user davinash commented on the issue:

    https://github.com/apache/geode/pull/529
  
    Thanks @kirklund , Yes Please you can merge this change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---