You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "pfyra (via GitHub)" <gi...@apache.org> on 2023/08/11 14:05:42 UTC
[GitHub] [mynewt-nimble] pfyra opened a new pull request, #1591: porting/npl/freertos: Add way of including HW specific header
pfyra opened a new pull request, #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591
As mentioned in the in_isr function, there is HW specific code in this file but there is no way to include a header file that defines the SCB etc. This PR adds a way to include a header file so it is possible to make this file compile without local changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] pfyra commented on a diff in pull request #1591: porting/npl/freertos: Add way of including HW specific header
Posted by "pfyra (via GitHub)" <gi...@apache.org>.
pfyra commented on code in PR #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1331125788
##########
porting/npl/freertos/src/npl_os_freertos.c:
##########
@@ -22,6 +22,10 @@
#include <string.h>
#include "nimble/nimble_npl.h"
+#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE
+#include NIMBLE_NPL_OS_EXTRA_INCLUDE
+#endif
+
Review Comment:
I suppose all ARM MCUs have the SCB so it should be enough to include a header file for the HW specific stuff. At least in my case (stm32) it is. I suppose everyone who use this code needs to add an include statement to this file (or modify it further).
It is a bit cumbersome to maintain changes to the nimble repo at our end since we want to use the nimble repo as a submodule and it is very close to work without changes. Having a possibility to specify a file to include here makes it possible for us to use nimble without any changes.
Perhaps there is a CMSIS file that can be included that specifies the SCB? That might introduce some unwanted dependencies though...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1591: porting/npl/freertos: Add way of including HW specific header
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1331092580
##########
porting/npl/freertos/src/npl_os_freertos.c:
##########
@@ -22,6 +22,10 @@
#include <string.h>
#include "nimble/nimble_npl.h"
+#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE
+#include NIMBLE_NPL_OS_EXTRA_INCLUDE
+#endif
+
Review Comment:
since in_isr() is HW specific anyway, why not just include required file here explicitly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] sjanc commented on a diff in pull request #1591: porting/npl/freertos: Add way of including HW specific header
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc commented on code in PR #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1335461067
##########
porting/npl/freertos/src/npl_os_freertos.c:
##########
@@ -22,6 +22,10 @@
#include <string.h>
#include "nimble/nimble_npl.h"
+#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE
+#include NIMBLE_NPL_OS_EXTRA_INCLUDE
+#endif
+
Review Comment:
fair enough, but could you put some comment above this include? explaining why it is needed etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] porting/npl/freertos: Add way of including HW specific header [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] pfyra commented on a diff in pull request #1591: porting/npl/freertos: Add way of including HW specific header
Posted by "pfyra (via GitHub)" <gi...@apache.org>.
pfyra commented on code in PR #1591:
URL: https://github.com/apache/mynewt-nimble/pull/1591#discussion_r1342327256
##########
porting/npl/freertos/src/npl_os_freertos.c:
##########
@@ -22,6 +22,10 @@
#include <string.h>
#include "nimble/nimble_npl.h"
+#ifdef NIMBLE_NPL_OS_EXTRA_INCLUDE
+#include NIMBLE_NPL_OS_EXTRA_INCLUDE
+#endif
+
Review Comment:
Certainly. I have added a comment now and I tried to keep it short but descriptive. To me, it is borderline obvious that you use this to avoid changes in the code and if other changes are required anyway then I guess people simply won't bother with this. Let me know what you think and I'll update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org