[GitHub] [ozone] ChenSammi commented on a diff in pull request #3701: HDDS-7155. [DiskBalancer] Create interface between SCM and DN

[GitBox <gi...@apache.org>]

ChenSammi commented on code in PR #3701:
URL: https://github.com/apache/ozone/pull/3701#discussion_r952165679


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/storage/DiskBalancerConfiguration.java:
##########
@@ -43,12 +43,12 @@ public final class DiskBalancerConfiguration {
           "utilization of the volume(used space to capacity ratio) differs" +
           " from the utilization of the datanode(used space to capacity ratio" +
           " of the entire datanode) no more than the threshold.")
-  private double threshold = 10d;
+  private String threshold = "10";
 
   @Config(key = "max.disk.throughputInMBPerSec", type = ConfigType.AUTO,
       defaultValue = "10", tags = {ConfigTag.DISKBALANCER},
       description = "The max balance speed.")
-  private double diskBandwidth = 10;
+  private long diskBandwidth = 10;

Review Comment:
   Please check the type of all key, use the proper type instead of ConfigType.AUTO if possible. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org