You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "LightGuard (via GitHub)" <gi...@apache.org> on 2025/01/29 21:14:26 UTC
[PR] [NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16 [incubator-kie-kogito-runtimes]
LightGuard opened a new pull request, #3836:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3836
Follow-up for https://github.com/apache/incubator-kie-issues/issues/1787. We're updating SpringBoot, which is using LogBack 1.5.16. It makes sense to keep the versions the same everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16 [incubator-kie-kogito-runtimes]
Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard commented on code in PR #3836:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3836#discussion_r1962151887
##########
kogito-codegen-modules/kogito-codegen-api/pom.xml:
##########
@@ -102,4 +102,4 @@
</dependencies>
-</project>
\ No newline at end of file
+</project>
Review Comment:
I have no idea why it is saying that is changing. Line endings maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16 [incubator-kie-kogito-runtimes]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on code in PR #3836:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3836#discussion_r1935196127
##########
kogito-codegen-modules/kogito-codegen-api/pom.xml:
##########
@@ -99,6 +99,10 @@
<artifactId>kogito-drools</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
Review Comment:
HI @LightGuard
This is strange, with regard of the ticket: why is this needed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16 [incubator-kie-kogito-runtimes]
Posted by "LightGuard (via GitHub)" <gi...@apache.org>.
LightGuard closed pull request #3836: [NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [NO-ISSUE][DEP UPDATE] Updating logback to 1.5.16 [incubator-kie-kogito-runtimes]
Posted by "gitgabrio (via GitHub)" <gi...@apache.org>.
gitgabrio commented on PR #3836:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3836#issuecomment-2623853848
Hi @LightGuard
I'm slightly confused about this PR:
1 IINW,, it seems to replicate changes done in the springboot one
2 it is not clear why there is a new dependency declared
3 I can't understand why it fails 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org